From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf-next] bpf, tracing: unbreak lttng Date: Mon, 26 Mar 2018 15:25:32 -0700 Message-ID: <24d0ff40-c6fd-6349-4a89-dffda22cb596@fb.com> References: <20180326220845.678423-1-ast@kernel.org> <20180326181532.587e9e2b@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , , , , To: Steven Rostedt , Alexei Starovoitov Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:38668 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbeCZW0X (ORCPT ); Mon, 26 Mar 2018 18:26:23 -0400 In-Reply-To: <20180326181532.587e9e2b@gandalf.local.home> Sender: netdev-owner@vger.kernel.org List-ID: On 3/26/18 3:15 PM, Steven Rostedt wrote: > On Mon, 26 Mar 2018 15:08:45 -0700 > Alexei Starovoitov wrote: > >> for_each_kernel_tracepoint() is used by out-of-tree lttng module >> and therefore cannot be changed. >> Instead introduce kernel_tracepoint_find_by_name() to find >> tracepoint by name. >> >> Fixes: 9e9afbae6514 ("tracepoint: compute num_args at build time") >> Signed-off-by: Alexei Starovoitov > > I'm curious, why can't you rebase? The first patch was never acked. because I think it makes sense to keep such things in the commit log and in the separate diff, so next developer is aware of what kind of minefield the tracpoints are. No wonder some maintainers refuse to add them.