netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, romain.perier@collabora.com,
	alexandre.torgue@st.com, peppe.cavallaro@st.com, plaes@plaes.org,
	andrew@lunn.ch, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()
Date: Tue, 22 Aug 2017 14:45:44 -0700	[thread overview]
Message-ID: <24d4774e-1b1b-fe8b-5d25-dcd7f7aae757@gmail.com> (raw)
In-Reply-To: <20170822.144414.545771080170074088.davem@davemloft.net>

On 08/22/2017 02:44 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 22 Aug 2017 14:26:47 -0700
> 
>> Priit reported that stmmac was crashing with the trace below. This is because
>> phy_attached_print() is called too early right after the PHY device has been
>> found, but before it has a driver attached, since that is only done in
>> phy_probe() which occurs later.
>>
>> Fix this by dealing with a possibly NULL phydev->drv point since that can
>> happen here, but could also happen if we voluntarily did an unbind of the
>> PHY device with the PHY driver.
>  ...
>> Tested-By: Priit Laes <plaes@plaes.org>
>> Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> "net-next"?  The commit which introduced this problem is in 'net', don't we want
> to fix it there?

Oh yes we do, somehow I thought the commit was just in "net-next" hence
the subject, the patch applies cleanly to "net" as well.

Thanks!
-- 
Florian

  reply	other threads:[~2017-08-22 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 21:26 [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print() Florian Fainelli
2017-08-22 21:44 ` David Miller
2017-08-22 21:45   ` Florian Fainelli [this message]
2017-08-22 21:49     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24d4774e-1b1b-fe8b-5d25-dcd7f7aae757@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=plaes@plaes.org \
    --cc=romain.perier@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).