From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C45AF7493 for ; Wed, 18 Oct 2023 05:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F33BC6 for ; Tue, 17 Oct 2023 22:55:35 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qszWg-0007hK-2U; Wed, 18 Oct 2023 07:55:26 +0200 Message-ID: <24f14f0f-2a1b-401d-b5f8-314387d0aaef@pengutronix.de> Date: Wed, 18 Oct 2023 07:55:21 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Content-Language: en-US, de-DE To: Jakub Kicinski , Marc Kleine-Budde Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, Maxime Coquelin , netdev@vger.kernel.org, Richard Cochran , Kurt Kanzenbach , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, Eric Dumazet , Jose Abreu , Simon Horman , Paolo Abeni , "David S. Miller" , linux-arm-kernel@lists.infradead.org, patchwork-jzi@pengutronix.de References: <20231010-stmmac_fix_auxiliary_event_capture-v1-0-3eeca9e844fa@pengutronix.de> <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> <20231014144428.GA1386676@kernel.org> <004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de> <20231017082618.4558ad06@kernel.org> <20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de> <20231017165042.30fa9061@kernel.org> From: Johannes Zink In-Reply-To: <20231017165042.30fa9061@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: j.zink@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Jakub, hi Marc, On 10/18/23 01:50, Jakub Kicinski wrote: > On Tue, 17 Oct 2023 22:27:41 +0200 Marc Kleine-Budde wrote: >>> Would be good to clarify what impact on device operation the problem >>> has. How would end user notice the problem? >>> Does it mean snapshots were always or never enabled, previously? >> >> On all dwmac devices not covered by dwmac-intel.c (INTEL 10/100/1000 >> Ethernet PCI driver), PPS capture can be requested from user-space, but >> is not enabled in HW. There is no error message or other feedback to the >> user space. The user space will not get any PPS events. >> >> As this change also affects the Intel driver, and we don't have any >> hardware to test, I think it's better that this goes via net-next to >> give it a bit more time of testing. I have also CC'ed Kurt in this series, as I know he has at least some hardware at hand, though I cannot tell whether he has any chance to test the PPS capture. Maybe he has a possibility to try it out. However, giving it a spin in net-next SGTM. > > SGTM, we can chalk it up to "never worked, doesn't hurt anyone" > and put it in net-next. But then the Fixes tag must go. > sure, that's fine for me. I will reword the commit messages and send a v2. Best regards, Johannes -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |