From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E98482D7DCD for ; Tue, 16 Sep 2025 12:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758026713; cv=none; b=gYDd472ZWceLBHC7WQ9lame3U/NwiV22Hq+3e8OxTxL7UhYzpdw+iQieIc93+LAZ121Tyikh02Zjc4cR5EK1qSjVzMUFPBxNjzcYouJTnCZX8QQQWje2XLihtqow+VTfxqmrAmMOESWEX/aJ2AhJKujB0mbI00e9COk0ml29A34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758026713; c=relaxed/simple; bh=FzUCUUXus0/lvP4HuQ7h69MpKibfnnx6lcJF1Jm+eMQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vGg1AgtpE3yBw02b5MnXEB8VvpTTKRLsstD+HeB4TBebsiwO70O/9oj4EMrojXw4GGEYYwJqkhWPKAAaR2Ah67a1tULVhXCcUU44heQ/ffKcIq484AQhqCUXwPxv/thHVHQGetHa5pkvnxCBzRGCjD3zINFNnttzc95WCcJm08k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wBmAO/DC; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wBmAO/DC" Message-ID: <25108422-5b8a-49ec-89f4-ac5b1453d369@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1758026699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FtOFTlB5Q16CW97J68iNpibAWAgBtX0/ZjlWESzeId4=; b=wBmAO/DCz89ZZFOgPw+uXFG825I59GaCYV50AWXAFWpG3awQOf9GpMJMiUwVdpB6GleEDr 9wZ1WNom6WbAE75pQXPrZWh7Wlsf+RzZCBVZ8LD+iI0mGFtoo36VAzDCIAwPGNlw/W7xJI 0zvn9Aew++9m51aQuy9bwr1Q+oMt3xA= Date: Tue, 16 Sep 2025 13:44:55 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next 1/2] ptp: describe the two disables in ptp_set_pinfunc() To: "Russell King (Oracle)" , Richard Cochran Cc: Ajay Kaher , Alexey Makhalov , Andrew Lunn , Broadcom internal kernel review list , Clark Wang , "David S. Miller" , David Woodhouse , Eric Dumazet , imx@lists.linux.dev, Jakub Kicinski , Jonathan Lemon , netdev@vger.kernel.org, Nick Shi , Paolo Abeni , Sven Schnelle , Vladimir Oltean , Wei Fang , Yangbo Lu References: Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 15/09/2025 15:42, Russell King (Oracle) wrote: > Accurately describe what each call to ptp_disable_pinfunc() is doing, > rather than the misleading comment above the first disable. This helps > to make the code more readable. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Vadim Fedorenko