From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Tetja Rediske <tetja@tetja.de>,
djduanjiong@gmail.com, netdev@vger.kernel.org,
steffen.klassert@secunet.com,
Neal Cardwell <ncardwell@google.com>,
David Miller <davem@davemloft.net>
Subject: Re: PROBLEM: IPv6 TCP-Connections resetting
Date: Sun, 07 Apr 2013 16:37:04 +0200 [thread overview]
Message-ID: <2517820.omWyusa00U@cpaasch-mac> (raw)
In-Reply-To: <1365270879.3887.4.camel@edumazet-glaptop>
On Saturday 06 April 2013 10:54:39 Eric Dumazet wrote:
> OK, it seems bug was added in commit
> ec18d9a2691d69cd14b48f9b919fddcef28b7f5c
> (ipv6: Add redirect support to all protocol icmp error handlers.)
>
> Not sure why Tetja Rediske bisected to
> 093d04d42fa094f6740bb188f0ad0c215ff61e2c
I made a setup to trigger the ICMPv6 Redirect.
Yes, the bug was added by ec18d9a26 (ipv6: Add redirect support to all
protocol icmp error handlers.), but prior to 093d04d4 (ipv6: Change skb->data
before using icmpv6_notify() to propagate redirect) the stack did not enter
tcp_v6_err upon a redirect message.
This, because inside icmpv6_notify, skb->data did not point to the inner IP
header. So, when icmpv6_notify looks up the protocol-handler, it will not
match on tcp_v6_err.
> Could you send a patch with this single line change (no cleanup), and
> a more detailed changelog, once the bug origin is clearly identified ?
Yes, will resend.
Cheers,
Christoph
--
IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://multipath-tcp.org
UCLouvain
--
next prev parent reply other threads:[~2013-04-07 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130405174828.310a02c3@trediske.ws.office.manitu.net>
2013-04-05 17:54 ` PROBLEM: IPv6 TCP-Connections resetting Neal Cardwell
2013-04-05 17:58 ` Eric Dumazet
2013-04-06 4:35 ` Hannes Frederic Sowa
2013-04-06 4:37 ` Hannes Frederic Sowa
2013-04-06 9:14 ` Christoph Paasch
2013-04-06 9:18 ` Christoph Paasch
2013-04-06 17:43 ` Sergei Shtylyov
2013-04-06 17:54 ` Eric Dumazet
2013-04-06 18:27 ` Tetja Rediske
2013-04-07 14:37 ` Christoph Paasch [this message]
2013-04-08 9:56 ` Tetja Rediske
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2517820.omWyusa00U@cpaasch-mac \
--to=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tetja@tetja.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).