From: Paul Burton <paul.burton@imgtec.com>
To: David Miller <davem@davemloft.net>
Cc: <matt.redfearn@imgtec.com>, <netdev@vger.kernel.org>,
<alexandre.torgue@st.com>, <peppe.cavallaro@st.com>,
<linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>,
<james.hogan@imgtec.com>
Subject: Re: [PATCH] net: stmmac: Meet alignment requirements for DMA
Date: Tue, 26 Sep 2017 21:30:56 -0700 [thread overview]
Message-ID: <2520219.WSsBr6LeCR@np-p-burton> (raw)
In-Reply-To: <20170926.195244.506518182147628099.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
Hi David,
On Tuesday, 26 September 2017 19:52:44 PDT David Miller wrote:
> From: Paul Burton <paul.burton@imgtec.com>
> Date: Tue, 26 Sep 2017 14:30:33 -0700
>
> > I'd suggest that at a minimum if you're unwilling to obey the API as
> > described in Documentation/DMA-API.txt then it would be beneficial
> > if you could propose a change to it such that it works for you, and
> > perhaps we can extend the API & its documentation to allow your
> > usage whilst also allowing us to catch broken uses.
>
> The networking driver code works fine as is.
>
> I also didn't write that ill-advised documentation in the DMA docs,
> nor the non-merged new MIPS assertion.
>
> So I'm trying to figure out on what basis I am required to do
> anything.
>
> Thank you.
Nobody said you wrote the documentation, but you do maintain code which
disobeys the documented DMA API & now you're being an ass about it
unnecessarily.
Nobody said that you are required to do anything, I suggested that it would be
beneficial if you were to suggest a change to the documented DMA API such that
it allows your usage where it currently does not. If you don't want to have
any input into that, and you actually think that your current approach of
ignoring the documented API is the best path forwards, then we're probably
done here & I'll be making a note to avoid yourself & anything under net/ to
whatever extent is possible...
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-09-27 4:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 11:13 [PATCH] net: stmmac: Meet alignment requirements for DMA Matt Redfearn
2017-09-23 1:26 ` David Miller
2017-09-26 13:57 ` Matt Redfearn
2017-09-26 14:23 ` David Laight
2017-09-26 17:34 ` David Miller
2017-09-26 18:48 ` Paul Burton
2017-09-26 20:33 ` David Miller
2017-09-26 21:30 ` Paul Burton
2017-09-27 2:52 ` David Miller
2017-09-27 4:30 ` Paul Burton [this message]
2017-09-27 4:53 ` David Miller
2017-09-27 5:23 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2520219.WSsBr6LeCR@np-p-burton \
--to=paul.burton@imgtec.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox