From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073BBC43381 for ; Tue, 5 Mar 2019 17:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5D1020661 for ; Tue, 5 Mar 2019 17:28:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbfCER2F (ORCPT ); Tue, 5 Mar 2019 12:28:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33986 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727334AbfCER2F (ORCPT ); Tue, 5 Mar 2019 12:28:05 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35BD930718C9; Tue, 5 Mar 2019 17:28:05 +0000 (UTC) Received: from ovpn-112-58.rdu2.redhat.com (ovpn-112-58.rdu2.redhat.com [10.10.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10A1F282D2; Tue, 5 Mar 2019 17:28:03 +0000 (UTC) Message-ID: <252cc21cc2ec219912a57e1fc09bf5b01f6ab92c.camel@redhat.com> Subject: Re: [PATCH net] qmi_wwan: Add support for Quectel EG12/EM12 From: Dan Williams To: Kristian Evensen , =?ISO-8859-1?Q?Bj=F8rn?= Mork Cc: Network Development , David Miller Date: Tue, 05 Mar 2019 11:28:03 -0600 In-Reply-To: References: <20190302123226.14589-1-kristian.evensen@gmail.com> <87o96t9v93.fsf@miraculix.mork.no> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 05 Mar 2019 17:28:05 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2019-03-02 at 22:19 +0100, Kristian Evensen wrote: > On Sat, Mar 2, 2019 at 4:00 PM Bjørn Mork wrote: > > I am not too happy about the double device id matching with extra > > magic > > applied. outside the device id table. It does not scale, and it > > does > > not play well at all with dynamic IDs. But I guess it's acceptable > > for > > two devices when it was ok for one, so > > > > Acked-by: Bjørn Mork > > > > But I assume this isn't the last device we've seen with this issue. > > Someone has already mention Quectel EM20. Maybe convert this code > > to a > > quirk for the next device and leave all the device specific magic > > in the > > device id table? Could even add a macro for the class match + > > quirk > > thing. > > (Appologies to Bjørn for receiving multiple copies of this email - I > forgot that the Gmail app sends HTML-encoded emails) > > Thanks for your feedback. My reasoning was the same. For one or two > devices, the current approach is (probably) ok. Any more, and a > different approach is needed. > > Looking through the documentation I have, it seems like most > Quectel-modems support the command used to change the > USB-configuration. Thus, I wouldn’t be surprised if all or most > existing Quectel-devices should have this quirk applied. I have a > couple of older modules, so I will look at how they behave with > different configurations. I will then either add the quirk soon or > when for example EM20 is available (unless someone else does it > earlier :)). Yeah, this should really be a new quirk from here on. Dan