netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gasper Zejn <zelo.zejn@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Kevin Yang <yyd@google.com>, netdev <netdev@vger.kernel.org>
Subject: Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast
Date: Mon, 15 Oct 2018 12:26:06 +0200	[thread overview]
Message-ID: <252ea882-bcd2-b205-7d68-541e88b5d617@gmail.com> (raw)
In-Reply-To: <CANn89iLOHxOOuGzqNODk0hNWJ7an0bZXs4G-8mQjq3WWhZPo9g@mail.gmail.com>


On 09. 10. 2018 19:26, Eric Dumazet wrote:
> On Tue, Oct 9, 2018 at 10:22 AM Gasper Zejn <zelo.zejn@gmail.com> wrote:
>> On 09. 10. 2018 19:00, Eric Dumazet wrote:
>>> On 10/09/2018 09:38 AM, Gasper Zejn wrote:
>>>> Hello,
>>>>
>>>> I am seeing interrupt storms of over 100k-900k local timer interrupts
>>>> when changing between network devices or networks with open TCP
>>>> connections when not using sch_fq (I was using pfifo_fast). Using sch_fq
>>>> makes the bug with interrupt storm go away.
>>>>
>>> That is for what kind of traffic ?
>>>
>>> If your TCP flows send 100k-3M packets per second, then yes, the pacing timers
>>> could be setup in the 100k-900k range.
>>>
>> Traffic is nowhere in that range, think of having a few browser tabs of
>> javascript rich
>> web pages open, mostly idle, for example slack, gmail or tweetdeck. No
>> significant
>> packet rate is needed, just open connections.
> No idea of what is going on really. A repro would be nice.

I've tried to isolate the issue as best I could. There seems to be an
issue if the TCP socket has keepalive set and send queue is not empty
and the route goes away.

https://github.com/zejn/bbr_pfifo_interrupts_issue

Hope this helps,
Gasper

  reply	other threads:[~2018-10-15 18:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 16:38 BBR and TCP internal pacing causing interrupt storm with pfifo_fast Gasper Zejn
2018-10-09 17:00 ` Eric Dumazet
2018-10-09 17:22   ` Gasper Zejn
2018-10-09 17:26     ` Eric Dumazet
2018-10-15 10:26       ` Gasper Zejn [this message]
2018-10-15 14:50         ` Eric Dumazet
2018-10-15 16:23           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252ea882-bcd2-b205-7d68-541e88b5d617@gmail.com \
    --to=zelo.zejn@gmail.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=yyd@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).