From: Tobias Brunner <tobias@strongswan.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net] macsec: Fix header length if SCI is added if explicitily disabled
Date: Mon, 24 Oct 2016 15:32:40 +0200 [thread overview]
Message-ID: <253edab5-98e6-60e0-0c29-2f1205a4dd1a@strongswan.org> (raw)
In-Reply-To: <20161024112822.GA28497@bistromath.localdomain>
> [snip]
>> @@ -440,12 +448,12 @@ static void macsec_fill_sectag(struct macsec_eth_header *h,
>> const struct macsec_secy *secy, u32 pn)
>> {
>> const struct macsec_tx_sc *tx_sc = &secy->tx_sc;
>> + bool sci_present = send_sci(secy);
>
> You're already computing this in macsec_encrypt() just before calling
> macsec_fill_sectag(), so you could pass it as argument instead of
> recomputing it.
Right, I'll send a v2. Would you like me to inline the send_sci()
function, as it will only be called once afterwards.
Regards,
Tobias
next prev parent reply other threads:[~2016-10-24 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:11 [PATCH net] macsec: Fix header length if SCI is added if explicitily disabled Tobias Brunner
2016-10-24 11:28 ` Sabrina Dubroca
2016-10-24 13:32 ` Tobias Brunner [this message]
2016-10-24 13:38 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253edab5-98e6-60e0-0c29-2f1205a4dd1a@strongswan.org \
--to=tobias@strongswan.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).