From: Aurelien Aptel <aaptel@nvidia.com>
To: Paolo Abeni <pabeni@redhat.com>,
linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com,
chaitanyak@nvidia.com, davem@davemloft.net, kuba@kernel.org
Cc: Yoray Zack <yorayz@nvidia.com>,
aurelien.aptel@gmail.com, smalin@nvidia.com, malin1024@gmail.com,
ogerlitz@nvidia.com, borisp@nvidia.com, galshalom@nvidia.com,
mgurtovoy@nvidia.com
Subject: Re: [PATCH v26 07/20] nvme-tcp: RX DDGST offload
Date: Tue, 25 Feb 2025 15:34:52 +0200 [thread overview]
Message-ID: <253plj6ywoz.fsf@nvidia.com> (raw)
In-Reply-To: <5d9340b1-02a5-4fa1-971e-a2a4baf77ef7@redhat.com>
Paolo Abeni <pabeni@redhat.com> writes:
>> +static inline bool nvme_tcp_ddp_ddgst_ok(struct nvme_tcp_queue *queue)
>
> 'inline' functions should be avoided in c files. Either drop the inline
> keyword or move the definition to a (local) include file.
Ok, we will drop the inline.
Thanks
next prev parent reply other threads:[~2025-02-25 13:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 9:52 [PATCH v26 00/20] nvme-tcp receive offloads Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2025-02-25 10:23 ` Paolo Abeni
2025-02-25 13:34 ` Aurelien Aptel
2025-02-25 17:15 ` Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2025-02-25 10:42 ` Paolo Abeni
2025-02-25 13:34 ` Aurelien Aptel [this message]
2025-02-21 9:52 ` [PATCH v26 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
2025-02-25 10:12 ` [PATCH v26 00/20] nvme-tcp receive offloads Paolo Abeni
2025-02-25 13:38 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253plj6ywoz.fsf@nvidia.com \
--to=aaptel@nvidia.com \
--cc=aurelien.aptel@gmail.com \
--cc=axboe@fb.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=davem@davemloft.net \
--cc=galshalom@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=malin1024@gmail.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=smalin@nvidia.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).