netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Aptel <aaptel@nvidia.com>
To: Paolo Abeni <pabeni@redhat.com>,
	linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
	sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com,
	chaitanyak@nvidia.com, davem@davemloft.net, kuba@kernel.org
Cc: Boris Pismenny <borisp@nvidia.com>,
	aurelien.aptel@gmail.com, smalin@nvidia.com, malin1024@gmail.com,
	ogerlitz@nvidia.com, yorayz@nvidia.com, galshalom@nvidia.com,
	mgurtovoy@nvidia.com, edumazet@google.com, dsahern@kernel.org,
	ast@kernel.org, jacob.e.keller@intel.com
Subject: Re: [PATCH v26 01/20] net: Introduce direct data placement tcp offload
Date: Tue, 25 Feb 2025 15:34:09 +0200	[thread overview]
Message-ID: <253seo2ywq6.fsf@nvidia.com> (raw)
In-Reply-To: <9d381da6-cef7-431e-be82-fd2888fc480a@redhat.com>

Paolo Abeni <pabeni@redhat.com> writes:
>> +     /* put in ulp_ddp_sk_del() */
>> +     dev_hold(netdev);
>
> You should use netdev_hold()/netdev_put() instead, with a paired reftracker.

Ok, we will pass the tracker as argument.

>>       flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);
>>       flush |= skb_cmp_decrypted(p, skb);
>> +     flush |= skb_is_ulp_crc(p) != skb_is_ulp_crc(skb);
>
> Possibly a `skb_cmp_ulp_crc()` helper would be cleaner.

Sure, we will make a skb_cmp_ulp_crc() helper.

Thanks

  reply	other threads:[~2025-02-25 13:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  9:52 [PATCH v26 00/20] nvme-tcp receive offloads Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2025-02-25 10:23   ` Paolo Abeni
2025-02-25 13:34     ` Aurelien Aptel [this message]
2025-02-25 17:15       ` Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2025-02-25 10:42   ` Paolo Abeni
2025-02-25 13:34     ` Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2025-02-21  9:52 ` [PATCH v26 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
2025-02-25 10:12 ` [PATCH v26 00/20] nvme-tcp receive offloads Paolo Abeni
2025-02-25 13:38   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=253seo2ywq6.fsf@nvidia.com \
    --to=aaptel@nvidia.com \
    --cc=ast@kernel.org \
    --cc=aurelien.aptel@gmail.com \
    --cc=axboe@fb.com \
    --cc=borisp@nvidia.com \
    --cc=chaitanyak@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=galshalom@nvidia.com \
    --cc=hch@lst.de \
    --cc=jacob.e.keller@intel.com \
    --cc=kbusch@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=malin1024@gmail.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=smalin@nvidia.com \
    --cc=yorayz@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).