From: Song Liu <songliubraving@fb.com>
To: kbuild test robot <lkp@intel.com>, David Miller <davem@davemloft.net>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>,
Martin Lau <kafai@fb.com>, Alexei Starovoitov <ast@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"liu.song.a23@gmail.com" <liu.song.a23@gmail.com>
Subject: Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()
Date: Thu, 26 Oct 2017 23:50:06 +0000 [thread overview]
Message-ID: <2552809E-4EBC-4F3D-94A4-41BE0ECB27C2@fb.com> (raw)
In-Reply-To: <201710261134.MUf5E7cp%fengguang.wu@intel.com>
> On Oct 25, 2017, at 8:13 PM, kbuild test robot <lkp@intel.com> wrote:
>
> Hi Song,
>
> [auto build test WARNING on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Song-Liu/tcp-add-tracepoint-trace_tcp_retransmit_synack/20171026-010651
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>
> vim +281 include/trace/events/tcp.h
>
> 241
> 242 TP_PROTO(const struct sock *sk, const struct request_sock *req),
> 243
> 244 TP_ARGS(sk, req),
> 245
> 246 TP_STRUCT__entry(
> 247 __field(const void *, skaddr)
> 248 __field(const void *, req)
> 249 __field(__u16, sport)
> 250 __field(__u16, dport)
> 251 __array(__u8, saddr, 4)
> 252 __array(__u8, daddr, 4)
> 253 __array(__u8, saddr_v6, 16)
> 254 __array(__u8, daddr_v6, 16)
> 255 ),
> 256
> 257 TP_fast_assign(
> 258 struct inet_request_sock *ireq = inet_rsk(req);
> 259 struct in6_addr *pin6;
> 260 __be32 *p32;
> 261
> 262 __entry->skaddr = sk;
> 263 __entry->req = req;
> 264
> 265 __entry->sport = ireq->ir_num;
> 266 __entry->dport = ntohs(ireq->ir_rmt_port);
> 267
> 268 p32 = (__be32 *) __entry->saddr;
> 269 *p32 = ireq->ir_loc_addr;
> 270
> 271 p32 = (__be32 *) __entry->daddr;
> 272 *p32 = ireq->ir_rmt_addr;
> 273
>> 274 #if IS_ENABLED(CONFIG_IPV6)
> 275 if (sk->sk_family == AF_INET6) {
> 276 pin6 = (struct in6_addr *)__entry->saddr_v6;
> 277 *pin6 = ireq->ir_v6_loc_addr;
> 278 pin6 = (struct in6_addr *)__entry->daddr_v6;
> 279 *pin6 = ireq->ir_v6_rmt_addr;
> 280 } else
>> 281 #endif
In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which generates
warnings like:
./include/trace/events/tcp.h:274:1: error: directive in argument list
./include/trace/events/tcp.h:281:1: error: directive in argument list
Seems these warning cannot be easily avoided. This is also the same pattern we
have been using in include/trace/events/tcp.h.
Any suggestions on how shall we proceed from here?
Thanks,
Song
next prev parent reply other threads:[~2017-10-26 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 23:57 [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack() Song Liu
2017-10-25 16:17 ` Song Liu
2017-10-26 3:13 ` kbuild test robot
2017-10-26 23:50 ` Song Liu [this message]
2017-10-27 2:01 ` Cong Wang
2017-10-27 5:06 ` Song Liu
2017-10-27 19:57 ` Alexei Starovoitov
2017-10-27 20:38 ` Alban Crequy
2017-10-27 20:58 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2552809E-4EBC-4F3D-94A4-41BE0ECB27C2@fb.com \
--to=songliubraving@fb.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=kbuild-all@01.org \
--cc=liu.song.a23@gmail.com \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).