From: Marc Dietrich <marvin24@gmx.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Chen-Yu Tsai <wens@csie.org>, Rhyland Klein <rklein@nvidia.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] net: rfkill: gpio: remove unused and obsoleteplatform parameters
Date: Sat, 22 Feb 2014 23:32:04 +0100 [thread overview]
Message-ID: <2556368.zbgmUK7WzX@ax5200p> (raw)
In-Reply-To: <20140221142349.GB10489@xps8300>
On Friday 21 February 2014 16:23:49 Heikki Krogerus wrote:
> Hi,
>
> On Fri, Feb 21, 2014 at 02:55:14PM +0100, Marc Dietrich wrote:
> > Am Donnerstag, 20. Februar 2014, 14:51:34 schrieb Heikki Krogerus:
> > > After upgrading to descriptor based gpios, the gpio numbers
> > > are not used anymore. The power_clk_name and the platform
> > > specific setup and close hooks are not used by anybody, and
> > > we should not encourage use of such things, so removing them.
> >
> > arch/arm/mach-tegra/board-paz00.c is still using platform data. Is there
> > some prerequisite patch I'm missing (3.14-rc3) or how can this file be
> > converted? We are waiting for DT support to arrive so we can finally
> > remove this file.
> True! It still set's the shutdown_gpio and reset_gpio members. I think
> I'll leave the header untouched and just clean net/rfkill/rfkill-gpio.c
> in this patch. We can remove the whole header after you guys have moved
> to DT.
Why? Just update the board file to remove those entries. I just checked that
it's working fine without. So if you don't mind, add a patch to remove the
entries as the first patch in your series.
Thanks
Marc
next prev parent reply other threads:[~2014-02-22 22:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 12:51 [PATCH 0/4] net: rfkill: gpio: clean up and a few new acpi ids Heikki Krogerus
2014-02-20 12:51 ` [PATCH 1/4] net: rfkill: gpio: remove unused and obsolete platform parameters Heikki Krogerus
2014-02-21 13:55 ` Marc Dietrich
2014-02-21 14:23 ` Heikki Krogerus
2014-02-22 22:32 ` Marc Dietrich [this message]
2014-02-24 8:38 ` [PATCH 1/4] net: rfkill: gpio: remove unused and obsoleteplatform parameters Heikki Krogerus
2014-02-24 8:42 ` [PATCH 1/4] net: rfkill: gpio: remove unused andobsoleteplatform parameters Marc Dietrich
2014-02-20 12:51 ` [PATCH 2/4] net: rfkill: gpio: remove gpio names Heikki Krogerus
2014-02-20 16:38 ` Stephen Warren
2014-02-21 1:55 ` Chen-Yu Tsai
[not found] ` <CAGb2v66-tDZhrm9dnXe+PdQTaLZbw20sw3uYzLor2eXpVWmPMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-21 5:35 ` Stephen Warren
2014-02-25 9:13 ` Linus Walleij
2014-02-25 17:35 ` Stephen Warren
[not found] ` <530CD45A.8050803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-03-07 2:51 ` Linus Walleij
2014-02-27 17:38 ` Gross, Mark
2014-02-27 17:47 ` Stephen Warren
2014-02-27 20:06 ` mark gross
2014-03-07 2:58 ` Linus Walleij
2014-02-20 12:51 ` [PATCH 3/4] net: rfkill: gpio: add ACPI ID for GPS module on Lenove Miix2 Heikki Krogerus
2014-02-20 12:51 ` [PATCH 4/4] net: rfkill: gpio: add ACPI IDs for a Broadcom bluetooth chip Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2556368.zbgmUK7WzX@ax5200p \
--to=marvin24@gmx.de \
--cc=davem@davemloft.net \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).