From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH net-next] udp: Add tracepoints to monitor skbs going in and out of a UDP socket Date: Thu, 04 Oct 2018 17:54:33 +0100 Message-ID: <25668.1538672073@warthog.procyon.org.uk> References: <153864184110.20296.16498481420320274305.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org To: David Ahern Return-path: In-Reply-To: Content-ID: <25667.1538672073.1@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Ahern wrote: > These do not add any real value. You are only dumping the skb address, Not in and of themselves, no - but in combination with tracepoints elsewhere, where you can use the skb address as a key to follow the lifetime of a particular skb. > and you can get the same effect with a probe on the function and dumping > the value of the register with the skb argument. Installing a probe requires various preconditions, including your kernel not being locked down and having the source around AIUI. Anyway, I've no especially strong feelings about this patch - it's been useful for me and it might be useful to others. David