netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Florian Westphal <fw@strlen.de>, Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Kuznetsov <wwfq@yandex-team.ru>,
	netdev@vger.kernel.org, zeil@yandex-team.ru
Subject: Re: [PATCH] ipv6: enable net.ipv6.route sysctls in network namespace
Date: Sat, 25 Sep 2021 09:25:38 -0600	[thread overview]
Message-ID: <25693a6e-1919-f02d-6026-46839ea11bf7@gmail.com> (raw)
In-Reply-To: <20210921153203.GK15906@breakpoint.cc>

On 9/21/21 9:32 AM, Florian Westphal wrote:
> Jakub Kicinski <kuba@kernel.org> wrote:
>> On Tue, 21 Sep 2021 09:22:04 +0300 Alexander Kuznetsov wrote:
>>> We want to increase route cache size in network namespace
>>> created with user namespace. Currently ipv6 route settings
>>> are disabled for non-initial network namespaces.
>>> Since routes are per network namespace it is safe
>>> to enable these sysctls.
> 
> Are routes accounted towards memcg or something like that?
> 
> Otherwise userns could start eating up memory by cranking the limit
> up to 11 and just adds a gazillion routes?
> 

Adding FIB entries I believe is now handled after commit:

commit 6126891c6d4f6f4ef50323d2020635ee255a796e
Author: Vasily Averin <vvs@virtuozzo.com>
Date:   Mon Jul 19 13:44:31 2021 +0300

    memcg: enable accounting for IP address and routing-related objects


The ip6_rt_max_size sysctl manages the number of dst entries (cached
dst's and exceptions) that can be created, and there should be some
limit that network namespace users can not exceed.

  reply	other threads:[~2021-09-25 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21  6:22 [PATCH] ipv6: enable net.ipv6.route sysctls in network namespace Alexander Kuznetsov
2021-09-21 13:09 ` Jakub Kicinski
2021-09-21 15:32   ` Florian Westphal
2021-09-25 15:25     ` David Ahern [this message]
2021-09-30  8:44   ` Alexander Al. Kuznetsov
2021-09-30 14:59 ` Eric W. Biederman
  -- strict thread matches above, loose matches on Subject: below --
2021-09-09 11:14 Alexander Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25693a6e-1919-f02d-6026-46839ea11bf7@gmail.com \
    --to=dsahern@gmail.com \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wwfq@yandex-team.ru \
    --cc=zeil@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).