From: maowenan <maowenan@huawei.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netanel@amazon.com, saeedb@amazon.com, zorik@amazon.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: Re: [PATCH net] net: ena: Add dependency for ENA_ETHERNET
Date: Sun, 22 Sep 2019 13:08:59 +0800 [thread overview]
Message-ID: <256c3d2c-e900-8182-48e4-fb1cfcb53a74@huawei.com> (raw)
In-Reply-To: <20190921200741.1c3289e8@cakuba.netronome.com>
On 2019/9/22 11:07, Jakub Kicinski wrote:
> On Fri, 20 Sep 2019 16:44:05 +0800, Mao Wenan wrote:
>> If CONFIG_ENA_ETHERNET=y and CONFIG_DIMLIB=n,
>> below erros can be found:
>> drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_dim_work':
>> ena_netdev.c:(.text+0x21cc): undefined reference to `net_dim_get_rx_moderation'
>> ena_netdev.c:(.text+0x21cc): relocation truncated to
>> fit: R_AARCH64_CALL26 against undefined symbol `net_dim_get_rx_moderation'
>> drivers/net/ethernet/amazon/ena/ena_netdev.o: In function `ena_io_poll':
>> ena_netdev.c:(.text+0x7bd4): undefined reference to `net_dim'
>> ena_netdev.c:(.text+0x7bd4): relocation truncated to fit:
>> R_AARCH64_CALL26 against undefined symbol `net_dim'
>>
>> After commit 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive
>> interrupt moderation"), it introduces dim algorithm, which configured by CONFIG_DIMLIB.
>>
>> Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation")
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>
> Thank you Mao, shortly after you posted your patch Uwe proposed to make
> DIMLIB a hidden symbol:
>
> https://lore.kernel.org/netdev/a85be675-ce56-f7ba-29e9-b749073aab6c@kleine-koenig.org/T/#t
>
> That patch will likely be applied soon, could you please rework your
> patch to use the "select" keyword instead of "depends". That's what
> other users do.
Ok, I will send v2.
>
>> diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
>> index 69ca99d..fe46df4 100644
>> --- a/drivers/net/ethernet/amazon/Kconfig
>> +++ b/drivers/net/ethernet/amazon/Kconfig
>> @@ -18,7 +18,7 @@ if NET_VENDOR_AMAZON
>>
>> config ENA_ETHERNET
>> tristate "Elastic Network Adapter (ENA) support"
>> - depends on PCI_MSI && !CPU_BIG_ENDIAN
>> + depends on PCI_MSI && !CPU_BIG_ENDIAN && DIMLIB
>> ---help---
>> This driver supports Elastic Network Adapter (ENA)"
>>
>
>
> .
>
next prev parent reply other threads:[~2019-09-22 5:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 8:44 [PATCH net] net: ena: Add dependency for ENA_ETHERNET Mao Wenan
2019-09-22 3:07 ` Jakub Kicinski
2019-09-22 5:08 ` maowenan [this message]
2019-09-22 5:38 ` [PATCH v2 net] net: ena: Select DIMLIB " Mao Wenan
2019-09-22 21:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256c3d2c-e900-8182-48e4-fb1cfcb53a74@huawei.com \
--to=maowenan@huawei.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=uwe@kleine-koenig.org \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox