From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0947BC4708E for ; Tue, 6 Dec 2022 12:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234261AbiLFMdS (ORCPT ); Tue, 6 Dec 2022 07:33:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbiLFMdA (ORCPT ); Tue, 6 Dec 2022 07:33:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9264629375 for ; Tue, 6 Dec 2022 04:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670329917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DHp3x7R/guV3hbeucoqTiz42buTvLFKB8vI9+m0vRAc=; b=XB0qFKtjp2diqKIbXbrDl+Hv2+SalZyn5OoK9sftT4BuLhO3yeerbX0hUijlaxu0DkdOUL m/7PR/be5spjmMN3FUZRwuqLF4SJ05dnKB8s8C1V0aRc71ntiE5Za7ycjXfo6IjHIApYvt /wAgHeQ87CAUgUlp+raTSU0nr0N5bVM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-203-wpDmphp8P0aa6CGP0Y93zQ-1; Tue, 06 Dec 2022 07:31:56 -0500 X-MC-Unique: wpDmphp8P0aa6CGP0Y93zQ-1 Received: by mail-wr1-f72.google.com with SMTP id k1-20020adfb341000000b0024215e0f486so3175120wrd.21 for ; Tue, 06 Dec 2022 04:31:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DHp3x7R/guV3hbeucoqTiz42buTvLFKB8vI9+m0vRAc=; b=zEgfVI07ZA2fXXJGlRszrG8XARk359EoaSG8x7DC6xm2C0yZjUAhA0ddDt8eaosR2I tfanDqiiAb+SLiz9BcVFElp60vtNT+pAugKCFCe7jl8aXBr5waKXtA1RYrrsU1h9w5OD JfSH9RVIlOqU8kbnSiU1HDz317+yGt3qBNS62SW1I9LRePSjyI5ID/Szg9oMTxkAUxur lkdGhfra4xH8d+9ffHF3HNTnlAoFvLD0+Eqzt2XwZrI63J27jbpiS2SdHSxkLN9DhuVL T3As4bf5WfPeaASVYnI8zZGokWsRqZk8wQEAJRDDcDZcn+KthV2Pp0V/xBzcEzj9IOdI SKCw== X-Gm-Message-State: ANoB5pkHoqN0NoR0Rz6lf8cWzrafpgjOjmcxEG8TfAV7BBmgg9mGNSGm x/383msGS+gZgHPB5kdY1GZNCLkFAaxUob+5v1s/mh47txEDyhedwT/DyRggOJaLsExcMJUEGe+ uoJ55hBHjuzT+pnJ5 X-Received: by 2002:adf:db85:0:b0:241:bfd7:de7 with SMTP id u5-20020adfdb85000000b00241bfd70de7mr50298119wri.254.1670329915715; Tue, 06 Dec 2022 04:31:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf7/qzzr0VuvbP4qZ7Yd3q9rLNeZH+c2AL9jutLoNZnaid8y/nFTvCdzJr8fgsaFlM4wi8oyFQ== X-Received: by 2002:adf:db85:0:b0:241:bfd7:de7 with SMTP id u5-20020adfdb85000000b00241bfd70de7mr50298102wri.254.1670329915442; Tue, 06 Dec 2022 04:31:55 -0800 (PST) Received: from gerbillo.redhat.com (146-241-106-100.dyn.eolo.it. [146.241.106.100]) by smtp.gmail.com with ESMTPSA id r2-20020a056000014200b002422bc69111sm20743265wrx.9.2022.12.06.04.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 04:31:55 -0800 (PST) Message-ID: <256f533f019b6392b41701707eb7aa056b2f16c0.camel@redhat.com> Subject: Re: [PATCH net-next v3 1/4] net: microchip: vcap: Add vcap_get_rule From: Paolo Abeni To: Horatiu Vultur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, Steen.Hegelund@microchip.com, lars.povlsen@microchip.com, daniel.machon@microchip.com, richardcochran@gmail.com, UNGLinuxDriver@microchip.com, olteanv@gmail.com Date: Tue, 06 Dec 2022 13:31:53 +0100 In-Reply-To: <20221203104348.1749811-2-horatiu.vultur@microchip.com> References: <20221203104348.1749811-1-horatiu.vultur@microchip.com> <20221203104348.1749811-2-horatiu.vultur@microchip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Sat, 2022-12-03 at 11:43 +0100, Horatiu Vultur wrote: > @@ -632,32 +264,22 @@ static int vcap_show_admin(struct vcap_control *vctrl, > struct vcap_admin *admin, > struct vcap_output_print *out) > { > - struct vcap_rule_internal *elem, *ri; > + struct vcap_rule_internal *elem; > + struct vcap_rule *vrule; > int ret = 0; > > vcap_show_admin_info(vctrl, admin, out); > - mutex_lock(&admin->lock); > list_for_each_entry(elem, &admin->rules, list) { Not strictly related to this patch, as the patter is AFAICS already there in other places, but I'd like to understand the admin->rules locking schema. It looks like addition/removal are protected by admin->lock, but traversal is usually lockless, which in turn looks buggy ?!? Note: as this patch does not introduce the mentioned behavior, I'm not going to block the series for the above. Thanks, Paolo > - ri = vcap_dup_rule(elem); > - if (IS_ERR(ri)) { > - ret = PTR_ERR(ri); > - goto err_unlock; > + vrule = vcap_get_rule(vctrl, elem->data.id); > + if (IS_ERR_OR_NULL(vrule)) { > + ret = PTR_ERR(vrule); > + break; > } > - /* Read data from VCAP */ > - ret = vcap_read_rule(ri); > - if (ret) > - goto err_free_rule; > + > out->prf(out->dst, "\n"); > - vcap_show_admin_rule(vctrl, admin, out, ri); > - vcap_free_rule((struct vcap_rule *)ri); > + vcap_show_admin_rule(vctrl, admin, out, to_intrule(vrule)); > + vcap_free_rule(vrule); > } > - mutex_unlock(&admin->lock); > - return 0; > - > -err_free_rule: > - vcap_free_rule((struct vcap_rule *)ri); > -err_unlock: > - mutex_unlock(&admin->lock); > return ret; > }