From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@kernel.org, pabeni@redhat.com,
kuba@kernel.org, ernis@linux.microsoft.com
Subject: Re: [PATCH iproute2-next 0/5] netshaper: Extend netshaper support
Date: Fri, 1 May 2026 14:13:54 -0700 [thread overview]
Message-ID: <25780d3d-3d5d-4aaf-9bdc-c21d7051232f@gmail.com> (raw)
In-Reply-To: <20260501081741.0e07ed4f@phoenix.local>
> This helps the compiler with optimization and static analysis.
>
> These are all minor issues in an otherwise well-structured patch series.
> The code properly uses designated initializers, validates input with
> appropriate helpers, and follows the error handling patterns correctly.
>
> With these small fixes, the series would be ready for inclusion.
>
> Best regards
Thanks for the feedback Stephen and David. I'll address these points in V2.
next prev parent reply other threads:[~2026-05-01 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 1:16 [PATCH iproute2-next 0/5] netshaper: Extend netshaper support Mohsin Bashir
2026-05-01 1:16 ` [PATCH iproute2-next 1/5] netshaper: Extract parse_scope() and parse_rate() helpers Mohsin Bashir
2026-05-01 17:47 ` David Ahern
2026-05-01 1:16 ` [PATCH iproute2-next 2/5] netshaper: Add bw-min and weight parameter support Mohsin Bashir
2026-05-01 17:50 ` David Ahern
2026-05-01 1:16 ` [PATCH iproute2-next 3/5] netshaper: Extend show output with parent, bw-min and weight Mohsin Bashir
2026-05-01 1:16 ` [PATCH iproute2-next 4/5] netshaper: Make handle id optional for node scope Mohsin Bashir
2026-05-01 1:16 ` [PATCH iproute2-next 5/5] netshaper: Add group command for creating scheduling hierarchies Mohsin Bashir
2026-05-01 15:17 ` [PATCH iproute2-next 0/5] netshaper: Extend netshaper support Stephen Hemminger
2026-05-01 21:13 ` Mohsin Bashir [this message]
2026-05-01 17:52 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25780d3d-3d5d-4aaf-9bdc-c21d7051232f@gmail.com \
--to=mohsin.bashr@gmail.com \
--cc=dsahern@kernel.org \
--cc=ernis@linux.microsoft.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox