From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498C1C433B4 for ; Wed, 14 Apr 2021 11:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F58F6113D for ; Wed, 14 Apr 2021 11:16:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348739AbhDNLQU (ORCPT ); Wed, 14 Apr 2021 07:16:20 -0400 Received: from gloria.sntech.de ([185.11.138.130]:33974 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232027AbhDNLQT (ORCPT ); Wed, 14 Apr 2021 07:16:19 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWdUu-0004eF-2u; Wed, 14 Apr 2021 13:15:52 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Ezequiel Garcia , Peter Geis Cc: Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." , Jose Abreu , "David S . Miller" , Jakub Kicinski , David Wu , kernel@collabora.com Subject: Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support Date: Wed, 14 Apr 2021 13:15:51 +0200 Message-ID: <2596687.TLnPLrj5Ze@diego> In-Reply-To: References: <1412-60762b80-423-d9eaa5@27901112> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Mittwoch, 14. April 2021, 13:03:25 CEST schrieb Peter Geis: > On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia wrote: > > > > +static void rk3566_set_to_rmii(struct rk_priv_data *bsp_priv) > > > > +{ > > > > + struct device *dev = &bsp_priv->pdev->dev; > > > > + > > > > + if (IS_ERR(bsp_priv->grf)) { > > > > + dev_err(dev, "%s: Missing rockchip,grf property\n", __func__); > > > > + return; > > > > + } > > > > + > > > > + regmap_write(bsp_priv->grf, RK3568_GRF_GMAC1_CON1, > > > > + RK3568_GMAC_PHY_INTF_SEL_RMII); > > > > +} > > > > + > > > > +static void rk3568_set_to_rgmii(struct rk_priv_data *bsp_priv, > > > > + int tx_delay, int rx_delay) > > > > +{ > > > > + struct device *dev = &bsp_priv->pdev->dev; > > > > + > > > > + if (IS_ERR(bsp_priv->grf)) { > > > > + dev_err(dev, "Missing rockchip,grf property\n"); > > > > + return; > > > > + } > > > > + > > > > + regmap_write(bsp_priv->grf, RK3568_GRF_GMAC0_CON1, > > > > + RK3568_GMAC_PHY_INTF_SEL_RGMII | > > > > + RK3568_GMAC_RXCLK_DLY_ENABLE | > > > > + RK3568_GMAC_TXCLK_DLY_ENABLE); > > > > + > > > > + regmap_write(bsp_priv->grf, RK3568_GRF_GMAC0_CON0, > > > > + RK3568_GMAC_CLK_RX_DL_CFG(rx_delay) | > > > > + RK3568_GMAC_CLK_TX_DL_CFG(tx_delay)); > > > > + > > > > + regmap_write(bsp_priv->grf, RK3568_GRF_GMAC1_CON1, > > > > + RK3568_GMAC_PHY_INTF_SEL_RGMII | > > > > + RK3568_GMAC_RXCLK_DLY_ENABLE | > > > > + RK3568_GMAC_TXCLK_DLY_ENABLE); > > > > + > > > > + regmap_write(bsp_priv->grf, RK3568_GRF_GMAC1_CON0, > > > > + RK3568_GMAC_CLK_RX_DL_CFG(rx_delay) | > > > > + RK3568_GMAC_CLK_TX_DL_CFG(tx_delay)); > > > > > > Since there are two GMACs on the rk3568, and either, or, or both may > > > be enabled in various configurations, we should only configure the > > > controller we are currently operating. > > Perhaps we should have match data (such as reg = <0>, or against the > address) to identify the individual controllers. Hmm, "reg" will be used by the actual mmio address of the controller, so matching against that should be the way I guess. We're already doing something similar for dsi: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c#n1170 Heiko