Re: [PATCH iwl-net v4] ice: Add netif_device_attach/detach into PF reset flow

[Dawid Osuchowski <dawid.osuchowski@linux.intel.com>]

On 21.08.2024 08:22, Maciej Fijalkowski wrote:
> On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
>> @@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)
>>   {
>>   	struct device *dev = ice_pf_to_dev(pf);
>>   	struct ice_hw *hw = &pf->hw;
>> +	struct ice_vsi *vsi = ice_get_main_vsi(pf);
> 
> we have an unwritten rule that is called 'reverse christmas tree' which
> requires us to have declarations of variables sorted from longest to
> shortest.
> 
> 	struct ice_vsi *vsi = ice_get_main_vsi(pf);
> 	struct device *dev = ice_pf_to_dev(pf);
> 	struct ice_hw *hw = &pf->hw;
> 	bool dvm;
> 	int err;
>

My apologies, I was not aware of that unwritten rule. Will fix in next 
revision, thanks. Other than that, does the rest of the changes look 
okay to you?

--Dawid