From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT:" <llvm@lists.linux.dev>
Subject: Re: [PATCH 1/2] net: systemport: Remove unused txchk accessors
Date: Tue, 15 Oct 2024 10:32:21 -0700 [thread overview]
Message-ID: <25cb1dfb-a0dd-44d9-ac35-bfbc66a82d1f@broadcom.com> (raw)
In-Reply-To: <20241015172948.xvb3xoed52zhaqtm@skbuf>
On 10/15/24 10:29, Vladimir Oltean wrote:
> On Tue, Oct 15, 2024 at 10:24:57AM -0700, Florian Fainelli wrote:
>> Vladimir reported the following warning with clang-16 and W=1:
>>
>> warning: unused function 'txchk_readl' [-Wunused-function]
>> BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET);
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'txchk_writel' [-Wunused-function]
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'tbuf_readl' [-Wunused-function]
>> BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET);
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>>
>> warning: unused function 'tbuf_writel' [-Wunused-function]
>> note: expanded from macro 'BCM_SYSPORT_IO_MACRO'
>
> I mean the warnings do say that the tbuf macros are unused too, yet you
> only remove txchk? I did ask yesterday if that should also be deleted,
> and with it the other unused transmit buffer macros?
> https://lore.kernel.org/netdev/20241014174056.sxcgikf4hhw2olp7@skbuf/
See my response to my own posting.
--
Florian
next prev parent reply other threads:[~2024-10-15 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 17:24 [PATCH 0/2] net: systemport: Minor IO macros changes Florian Fainelli
2024-10-15 17:24 ` [PATCH 1/2] net: systemport: Remove unused txchk accessors Florian Fainelli
2024-10-15 17:29 ` Vladimir Oltean
2024-10-15 17:32 ` Florian Fainelli [this message]
2024-10-15 17:30 ` Florian Fainelli
2024-10-15 17:24 ` [PATCH 2/2] net: systemport: Move IO macros to header file Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25cb1dfb-a0dd-44d9-ac35-bfbc66a82d1f@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=justinstitt@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox