From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD316C4332F for ; Thu, 10 Nov 2022 11:18:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiKJLSB (ORCPT ); Thu, 10 Nov 2022 06:18:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiKJLR7 (ORCPT ); Thu, 10 Nov 2022 06:17:59 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A6936F369 for ; Thu, 10 Nov 2022 03:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668079022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+muvBkZLZGJhUWEuMfjEjy7/lkmMxnkjLutmEjVI01k=; b=D/lV3hv0DELYjQbaNjNt4JBYKyufPsr8U6jOVILLGGaPob+8DmXfPWV33vfW9U6FXnl4zI DqukSPdcTvlPWD/FaC2lWf2MeVlos+qIb8Nhr+BetaqfzFg9UvIlP2PCo4kpwig5LbO/Yp 6G/5WEqxeimtmaL/Sovb27CqKMg1/Wk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-638-CnmYumMyMkaxKXj3ko5jVQ-1; Thu, 10 Nov 2022 06:17:01 -0500 X-MC-Unique: CnmYumMyMkaxKXj3ko5jVQ-1 Received: by mail-ed1-f71.google.com with SMTP id l18-20020a056402255200b004633509768bso1266932edb.12 for ; Thu, 10 Nov 2022 03:17:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+muvBkZLZGJhUWEuMfjEjy7/lkmMxnkjLutmEjVI01k=; b=7oX/zlUmzHO9x+kmGTMjx69VqGgvZuULwp6SgnCViy75GA3ySNoCqAlpNqaX513Vcb chfyrbW9Fi/hoIOAzONUBHYUmYp+JIDSW2/819rtriYp/8vdTrPeswLBDSnijtEhyGJn ZIiFF6JVQqVrbaRvCIcA5uK6t+gGXIApsFd7y7/My6cQB8GJQckU3CTR3tFalaHZGs4x Lz352INJLl9kr+uotV/AD5zdKNCh0l1DuKRKHM/unVw7b+lhtup5/RULF+B0B3S+DlwJ 9x5sbmfj6980gZK3j/YXgZJ1FAqKoz3z9XIYRJEaWkNBfWTNG0J3vg+UV0fKNuUM3KhE Tvng== X-Gm-Message-State: ACrzQf0Vm1RKSTN2gwFxl47uobb6FeWvuZiSwlmZufDRQZIunj6XlxLQ 1CqTU1uBxHZoiVnOFHQz9epm77Rdeh3aq8f/odMglEdjah+TVzEZBQ2i24Adx2jpFUhjINjfkim kQDkMRKyAWzGEIwh3 X-Received: by 2002:a17:906:85cc:b0:7ad:db82:d071 with SMTP id i12-20020a17090685cc00b007addb82d071mr2761964ejy.200.1668079020169; Thu, 10 Nov 2022 03:17:00 -0800 (PST) X-Google-Smtp-Source: AMsMyM6FXG985xkGc/06Zy/PC9znx8nG5fUVqvHycIE2C/UkOmnf0vOLDRhVuy1p6ZKwoZ2lx5Oy8g== X-Received: by 2002:a17:906:85cc:b0:7ad:db82:d071 with SMTP id i12-20020a17090685cc00b007addb82d071mr2761955ejy.200.1668079019930; Thu, 10 Nov 2022 03:16:59 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id r23-20020aa7d597000000b004638ba0ea96sm8244703edq.97.2022.11.10.03.16.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 03:16:59 -0800 (PST) Message-ID: <25cfe9e2-f097-0b5e-9342-1ed6308bbdbc@redhat.com> Date: Thu, 10 Nov 2022 12:16:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 3/3] Bluetooth: btusb: Add a parameter to let users disable the fake CSR force-suspend hack To: Luiz Augusto von Dentz , Swyter Cc: marcel@holtmann.org, johan.hedberg@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, luiz.von.dentz@intel.com, quic_zijuhu@quicinc.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Jack , Paul Menzel References: <20221029202454.25651-1-swyterzone@gmail.com> <20221029202454.25651-3-swyterzone@gmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Luiz, On 11/9/22 23:39, Luiz Augusto von Dentz wrote: > Hi Swyter, > > On Wed, Nov 9, 2022 at 1:30 PM Swyter wrote: >> >> On 09/11/2022 21:49, Luiz Augusto von Dentz wrote: >>> Hi Ismael, >>> >>> On Sat, Oct 29, 2022 at 1:25 PM Ismael Ferreras Morezuelas >>> wrote: >>>> >>>> A few users have reported that their cloned Chinese dongle doesn't >>>> work well with the hack Hans de Goede added, that tries this >>>> off-on mechanism as a way to unfreeze them. >>>> >>>> It's still more than worthwhile to have it, as in the vast majority >>>> of cases it either completely brings dongles to life or just resets >>>> them harmlessly as it already happens during normal USB operation. >>>> >>>> This is nothing new and the controllers are expected to behave >>>> correctly. But yeah, go figure. :) >>>> >>>> For that unhappy minority we can easily handle this edge case by letting >>>> users disable it via our «btusb.disable_fake_csr_forcesuspend_hack=1» kernel option. >>> >>> Don't really like the idea of adding module parameter for device >>> specific problem. >> >> It's not for a single device, it's for a whole class of unnamed devices >> that are currently screwed even after all this. >> >> >>>> - ret = pm_runtime_suspend(&data->udev->dev); >>>> - if (ret >= 0) >>>> - msleep(200); >>>> - else >>>> - bt_dev_warn(hdev, "CSR: Couldn't suspend the device for our Barrot 8041a02 receive-issue workaround"); >>>> + ret = pm_runtime_suspend(&data->udev->dev); >>>> + if (ret >= 0) >>>> + msleep(200); >>>> + else >>>> + bt_dev_warn(hdev, "CSR: Couldn't suspend the device for our Barrot 8041a02 receive-issue workaround"); >>> >>> Is this specific to Barrot 8041a02? Why don't we add a quirk then? >>> >> >> We don't know how specific it is, we suspect the getting stuck thing happens with Barrot controllers, >> but in this world of lasered-out counterfeit chip IDs you can never be sure. Unless someone decaps them. >> >> Hans added that name because it's the closest thing we have, but this applies to a lot of chips. >> So much that now we do the hack by default, for very good reasons. >> >> So please reconsider, this closes the gap. >> >> With this last patch we go from ~+90% to almost ~100%, as the rest of generic quirks we added >> don't really hurt; even if a particular dongle only needs a few of the zoo of quirks we set, >> it's alright if we vaccinate them against all of these, except some are "allergic" >> against this particular "vaccine". Let people skip this one. :-) >> >> You know how normal BT controllers are utterly and inconsistently broken, now imagine you have a whole host >> of vendors reusing a VID/PID/version/subversion, masking as a CSR for bizarre reasons to avoid paying >> any USB-IF fees, or whatever. That's what we are fighting against here. > > I see, but for suspend in particular, can't we actually handle it > somehow? Note this is not about suspend. This is about a workaround where we runtime-suspend the HCI once, before initializing it and then actually disable runtime suspend (unless BT is turned off) because the USB remote wakeup functionality is also broken on these. IIRC the problem was that without the runtime suspend the HCI seems to work, but any events from the HCI to the host which are not direct responses to a request from the host, like a known previously paired BT device trying to connect would not get registered by the HCI. At least not until the host actually requested something from the HCI, e.g. starting a scan for new devices would all of a sudden cause the known paired device to show up. My theory here is that during init the Windows drivers at least runtime suspend the HCI once (or leave it idle long enough for Windows to do this) and somehow these clones rely on that for setting up some of their host notification functionality. > I mean if we can detect the controller is getting stuck and > print some information and flip the quirk? Detection of devices which need the "runtime-suspend once" workaround is almost impossible since the problem is the lack of unsolicited messages from the HCI, which can be normal if no BT "clients" are in use during probe. > Otherwise Im afraid this > parameter will end up always being set by distros to avoid suspend > problems. The flag is Swyter is suggesting is actually to disable the workaround, which is currently enabled for all USB BT dongles identified as being a CSR clone. Most clones work fine with it, with many needing it, but some clones seem to not like the workaround and behave undesirable if we runtime suspend them once. So the flag is to disable the workaround to make these last 5% of these (really cheap, bottom of the barrel quality) clones work. Since 95% of the clones do work with the workaround distro's enabling the flag by default would be a bad idea and I don't expect them to do this. Regards, Hans