From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BAE117555; Fri, 13 Feb 2026 17:50:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771005015; cv=none; b=bw/Qaz1bqGlhum04iHpwdCrKmR/OJ/YkP3I6NpDL2ENK4nOnpTcxTBKZDHZ4BTzmPuBt39ohzvJFB4+KUvxwe1Yl9dDrpVClSy94NBMzeYoD+8SoJtzxV7DC44Zi4TvoM9VBrZ0QYbSC+v05eBwfiNsoyyc4JiAdBXVXvh8ntjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771005015; c=relaxed/simple; bh=yV+n5t3bhZiNowfgdaluBYucTqAeFF0YgQPwfgowN1s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XNzJoSMNQ79uEKe/xnImSu6nIKTR0IAfnrPgvACfrw/OaDR7QQ34NgRPyw1suxoVK/MAn1AXqMvJXeb+qn4s3jwweAi+kxH9X1bIpwCp6veoKg5NexA7pgdaoG6D3W7zvyTPWRCsEsHeQ7+xPMBIcXFr1lYCL2QVA7I6Qdm+s64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bUPi1LNk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bUPi1LNk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B99C116C6; Fri, 13 Feb 2026 17:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771005015; bh=yV+n5t3bhZiNowfgdaluBYucTqAeFF0YgQPwfgowN1s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bUPi1LNkE7jZCCQU2LXR+gJvBN7Iq7Lle+VGZ4jeLizNCXmi8zEC72/e5evMOgoOr LkwmdP+9fCdfmdxVAxiscNnlL+D0mDMGfkOxr3ay08CBnwniwJvN9aA33/0NBBqGj3 avzStgkmpaTLR/WOFBQKWsx2vwenPNu2GUZq+CAqGSPsDQZKNpCrWByKQ9xiBHrKyN NxoCGW8QUuThGdKnDpnIOnm7pVGAAHTF+SwvNLSIuoyA4MHarVvx3LQWt4Uo89OOk/ vtHK248MPDsN6gbxzBC+w/M6Dj0q6c5BndOowlras0u9f/WFbCIiqHLfVv8cJp2j5L ny/gl8S07LFoA== Message-ID: <25d8d1ab-b01c-4416-9f8d-9f29e59dc781@kernel.org> Date: Fri, 13 Feb 2026 18:50:09 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/6] net: sched: introduce qdisc-specific drop reason tracing To: Paolo Abeni , netdev@vger.kernel.org, Eric Dumazet , "David S. Miller" , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: bpf@vger.kernel.org, Jakub Kicinski , horms@kernel.org, jiri@resnulli.us, edumazet@google.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, atenart@redhat.com, carges@cloudflare.com, kernel-team@cloudflare.com References: <177039500964.2258217.2989656069254156812.stgit@firesoul> <177039506239.2258217.7863252279149995024.stgit@firesoul> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/02/2026 09.46, Paolo Abeni wrote: > On 2/11/26 9:36 AM, Paolo Abeni wrote: >> On 2/6/26 5:24 PM, Jesper Dangaard Brouer wrote: >>> @@ -593,7 +591,7 @@ static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch) >>> while ((skb = dequeue_packet(sch, q, &credit_change, now))) { >>> if (!q->drop_early && must_drop(sch, q, skb)) { >>> drop_and_retry(q, skb, sch, >>> - SKB_DROP_REASON_QDISC_CONGESTED); >>> + QDISC_DROP_CONGESTED); >> >> An explicit cast is needed above to avoid compiler warning (or you can >> change drop_and_retry() signature). > > I see that the type confusion issues are handled for good by later > patches in the series, but I still think it would be better to avoid > introducing them with explicit casts as needed (removed by later patches). > >> Also a few lines below there is another drop_and_retry() calls that is >> not converted. > > I see it's handled by a later patch. I guess it would be useful to > mention such fact in the commit message. Yes, this is handled in patch 3/6. I acknowledge this is annoying from a review perspective, and also wrong because I'm leaving compiler warning that I'm fixing up later. The reason for splitting it out into a separate patch was because I wanted document (in commit desc) the special usage of SKB_NOT_DROPPED_YET as a sentinel value. I'm leaning towards folding patch 3 into this patch 1, as suggested by Toke. --Jesper