From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FA0C282C4 for ; Tue, 12 Feb 2019 18:56:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0476B222C0 for ; Tue, 12 Feb 2019 18:56:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YuWhmvbo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730965AbfBLS4Z (ORCPT ); Tue, 12 Feb 2019 13:56:25 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40403 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbfBLS4Z (ORCPT ); Tue, 12 Feb 2019 13:56:25 -0500 Received: by mail-wm1-f65.google.com with SMTP id q21so4200860wmc.5 for ; Tue, 12 Feb 2019 10:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=xXoUBelJfZZ7fJslnDyXyxQl+PQ+6mANopTMAPQ94qc=; b=YuWhmvbo1mlf8ifaYqhZ8tzNMFhrPDxPMSbx34h2HGVRJfXe+ag4sHo0uvtCcBkau3 31sLBjUwqZzeTae7hDVUcA6jA/g6KoAQQlIiyEmqNpf3e5LRStYCH+ZpLVHTzrMUzwRX 2eF2DCaHXc6poP1mUdp3TjEOQQ/9/JIp+fmhySYLNyfWKat5EH4rvxaUI7CEPOffEUHo Qp7BjcI9X+BwNl2OfAAZE2OVl5Sa3zh/ojfo+uaTm98LjLjRAfHha7kJkyxpmCPP864D mH1E22T3RYX8SoNWuU5yoqcSHCkL57XgW09kBqlLqLOovMZVPqltpCCrZtu3rmR34Q/V ngpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=xXoUBelJfZZ7fJslnDyXyxQl+PQ+6mANopTMAPQ94qc=; b=Hf/R23yg5V5Lb56BXetjE25mBI5sTAbZ32JMs8zviV7y0j0EXXaTjbJYSJihoCmn/4 MW5oajCa9U4pLA9oJDrHc2R0zAg/pt1WdVK7vjqqvfOFNKZ6ogW4QrRbzaPFYyaYx9LW k0tYML+Emec1Zw2hHSHAkKEUq1YzuOBsHf3Vtd2Fh94pthgpRP+NEprXuZHTDODPdKnZ rEboH2uPdkYCnTk7QB/CwaQXd8GTfYf1mQa1lvheusoMULlMj/YzRis1fcPvu1MV1giC FEMI8EPo6B9MvpbuRp+ABTx3VVcuLov1p7TeJVIls0m2BayzCoTaZst4oWYaaZtApYCy 68NQ== X-Gm-Message-State: AHQUAuakoS844hTsCYNEVcEecNz8ZUwPSci6pL5YbRRe3IrWs4gCu3M8 tHoKLe+tJ/P5GDj2wH6tOeM= X-Google-Smtp-Source: AHgI3IaCwybDbUE6gbcCcW9tiLeSiPiP6dPp8Y6X1HY5uClrHz/BGEx9Gjtl47uQgXY4YBfmxADZ7A== X-Received: by 2002:a1c:4e17:: with SMTP id g23mr272829wmh.78.1549997783152; Tue, 12 Feb 2019 10:56:23 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:788d:bad3:281d:6cd0? (p200300EA8BF1E200788DBAD3281D6CD0.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:788d:bad3:281d:6cd0]) by smtp.googlemail.com with ESMTPSA id h17sm9017474wrq.17.2019.02.12.10.56.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 10:56:22 -0800 (PST) From: Heiner Kallweit Subject: [PATCH net] net: phy: fix interrupt handling in non-started states To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" , Russell King - ARM Linux Message-ID: <25e86edc-0b88-8c03-b692-776e971331f2@gmail.com> Date: Tue, 12 Feb 2019 19:56:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org phylib enables interrupts before phy_start() has been called, and if we receive an interrupt in a non-started state, the interrupt handler returns IRQ_NONE. This causes problems with at least one Marvell chip as reported by Andrew. Fix this by handling interrupts the same as in phy_mac_interrupt(), basically always running the phylib state machine. It knows when it has to do something and when not. This change allows to handle interrupts gracefully even if they occur in a non-started state. Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") Reported-by: Andrew Lunn Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 189cd2048c3a..ca5e0c0f018c 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -762,9 +762,6 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat) { struct phy_device *phydev = phy_dat; - if (!phy_is_started(phydev)) - return IRQ_NONE; /* It can't be ours. */ - if (phydev->drv->did_interrupt && !phydev->drv->did_interrupt(phydev)) return IRQ_NONE; -- 2.20.1