From: Paolo Abeni <pabeni@redhat.com>
To: Shigeru Yoshida <syoshida@redhat.com>,
jmaloy@redhat.com, ying.xue@windriver.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, tung.q.nguyen@endava.com
Subject: Re: [PATCH net-next] tipc: Return -EINVAL on error from addr2str() methods
Date: Thu, 10 Oct 2024 11:39:24 +0200 [thread overview]
Message-ID: <25f50405-e36c-44a3-8045-3cc569b37a1e@redhat.com> (raw)
In-Reply-To: <20241008142442.652219-1-syoshida@redhat.com>
On 10/8/24 16:24, Shigeru Yoshida wrote:
> The return value 1 on error of the addr2str() methods are not
> descriptive. Return -EINVAL instead.
>
> Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
I'm sorry if I gave conflicting advice in the past, but I now think this
patch falls under the 'small cleanup patches' category we are actively
discouraging outside the scope of a wider (functional) change:
https://lore.kernel.org/netdev/20241009-doc-mc-clean-v2-1-e637b665fa81@kernel.org/
Thanks,
Paolo
prev parent reply other threads:[~2024-10-10 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 14:24 [PATCH net-next] tipc: Return -EINVAL on error from addr2str() methods Shigeru Yoshida
2024-10-10 9:39 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f50405-e36c-44a3-8045-3cc569b37a1e@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syoshida@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@endava.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).