From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [RFC] net: qcom/emac: mdiobus-dev fwnode should point to emac-adev Date: Thu, 25 Jan 2018 09:40:45 -0600 Message-ID: <25f763a5-ffcf-c668-105f-6534555c3595@codeaurora.org> References: <1516860879-15798-1-git-send-email-dongsheng.wang@hxt-semitech.com> <20180125141515.GB16547@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: hpuranik@codeaurora.org, yu.zheng@hxt-semitech.com, netdev@vger.kernel.org, Marcin Wojtas To: Andrew Lunn , Wang Dongsheng Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbeAYPks (ORCPT ); Thu, 25 Jan 2018 10:40:48 -0500 In-Reply-To: <20180125141515.GB16547@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01/25/2018 08:15 AM, Andrew Lunn wrote: > If i'm reading your patch correctly, you are looking for the MDIO > reset in the MAC node. This is wrong. It is an MDIO property, so > should be in the MDIO device. Once we have figured out how to > represent MDIO busses in ACPI, the reset will be in the MDIO node. Just FYI, the MDIO controller in the EMAC is integrated, so I can't see us creating a separate Device Tree or ACPI node/property for it. Granted, the code in emac-phy.c:emac_phy_config() that registers the MDIO bus is convoluted, so maybe there's an opportunity to replace some/all of that code with some generic API. Maybe we need something like acpi_mdiobus_register() like we have of_mdiobus_register(). -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.