From: Jay Vosburgh <fubar@us.ibm.com>
To: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, vyasevic@redhat.com
Subject: Re: [PATCH net-next 0/6] net/core, bonding: dev_uc_sync fixes, bonding update
Date: Fri, 31 May 2013 08:56:30 -0700 [thread overview]
Message-ID: <26013.1370015790@death.nxdomain> (raw)
In-Reply-To: <20130531152812.GB2910@sbohrermbp13-local.rgmadvisors.com>
Shawn Bohrer <shawn.bohrer@gmail.com> wrote:
>On Fri, May 31, 2013 at 01:31:55AM -0700, David Miller wrote:
>> From: Jay Vosburgh <fubar@us.ibm.com>
>> Date: Thu, 30 May 2013 17:55:38 -0700
>>
>> > This patch set includes 6 patches: four fixes to the dev_mc_sync /
>> > dev_mc_unsync system; and two patches to bonding, one to utilize the sync
>> > / unsync functions, and another minor fix related to MAC address handling.
>>
>> These look like fixes that should go into net, why target net-next?
>
>In my oppinion 0-4 should go into net since they fix the bug I
>reported in:
>
>http://comments.gmane.org/gmane.linux.network/270477
>
>I've tested patches 0-4 of this series so feel free to add my tested
>by to those:
>
>Tested-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
>
>From just a casual observation of patch 5-6 they do not appear to be
>bug fixes which is why this was probably marked net-next.
They're against net-next because I was working to convert
bonding to dev_sync/unsync against net-next and neglected to rebase then
before I posted. The bonding patches (5 and 6) do fix a couple of bugs
related to MAC address handling on s390 (the lack of additional unicast
address propagation to the slaves makes qeth unhappy in some cases), so
arguably they could go either way, but I'm ok with those in net-next if
it's an issue.
I do agree that 1-4 should go into net, once Vlad gives them a
look.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2013-05-31 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 0:55 [PATCH net-next 0/6] net/core, bonding: dev_uc_sync fixes, bonding update Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 1/6] net/core: __hw_addr_create_ex does not initialize sync_cnt Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 2/6] net/core: __hw_addr_unsync_one refcount leak synced Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 3/6] net/core: __hw_addr_sync_one / _multiple broken Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 4/6] net/core: dev_mc_sync_multiple calls wrong helper Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 5/6] bonding: Convert hw addr handling to sync/unsync, support ucast addresses Jay Vosburgh
2013-05-31 0:55 ` [PATCH net-next 6/6] bonding: disallow change of MAC if fail_over_mac enabled Jay Vosburgh
2013-05-31 8:31 ` [PATCH net-next 0/6] net/core, bonding: dev_uc_sync fixes, bonding update David Miller
2013-05-31 15:28 ` Shawn Bohrer
2013-05-31 15:56 ` Jay Vosburgh [this message]
2013-05-31 16:01 ` Vlad Yasevich
2013-05-31 17:27 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26013.1370015790@death.nxdomain \
--to=fubar@us.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shawn.bohrer@gmail.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).