From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 3/6] r8169: don't reset tx ring indexes in rtl8169_tx_clear
Date: Sat, 30 May 2020 23:56:14 +0200 [thread overview]
Message-ID: <261f63a4-1027-ca1b-6a76-e0eacda72998@gmail.com> (raw)
In-Reply-To: <443c14ac-24b8-58ba-05aa-3803f1e5f4ab@gmail.com>
In places where the indexes have to be reset, we call
rtl8169_init_ring_indexes() anyway after rtl8169_tx_clear().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 6fcd35ac8..43652c450 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -3955,7 +3955,6 @@ static void rtl8169_tx_clear_range(struct rtl8169_private *tp, u32 start,
static void rtl8169_tx_clear(struct rtl8169_private *tp)
{
rtl8169_tx_clear_range(tp, tp->dirty_tx, NUM_TX_DESC);
- tp->cur_tx = tp->dirty_tx = 0;
netdev_reset_queue(tp->dev);
}
--
2.26.2
next prev parent reply other threads:[~2020-05-30 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 21:52 [PATCH net-next 0/6] r8169: again few improvements Heiner Kallweit
2020-05-30 21:54 ` [PATCH net-next 1/6] r8169: change driver data type Heiner Kallweit
2020-05-31 5:17 ` Stephen Hemminger
2020-05-31 7:57 ` Heiner Kallweit
2020-05-30 21:55 ` [PATCH net-next 2/6] r8169: enable WAKE_PHY as only WoL source when runtime-suspending Heiner Kallweit
2020-05-30 21:56 ` Heiner Kallweit [this message]
2020-05-30 21:57 ` [PATCH net-next 4/6] r8169: move some calls to rtl8169_hw_reset Heiner Kallweit
2020-05-30 21:58 ` [PATCH net-next 5/6] r8169: make rtl8169_down central chip quiesce function Heiner Kallweit
2020-05-30 21:59 ` [PATCH net-next 6/6] r8169: improve handling power management ops Heiner Kallweit
2020-05-31 4:37 ` [PATCH net-next 0/6] r8169: again few improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=261f63a4-1027-ca1b-6a76-e0eacda72998@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).