From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev Date: Tue, 05 Dec 2017 14:50:55 +0100 Message-ID: <2621660.olL7LkYlpq@amdc3058> References: <60d598946ac219440cbb1fabed05964e806ebc5f.1512454057.git.fthain@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org To: Finn Thain Return-path: In-reply-to: <60d598946ac219440cbb1fabed05964e806ebc5f.1512454057.git.fthain@telegraphics.com.au> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote: > It is misleading to call a functional resource a "device". In adopting > the Linux Driver Model, the struct device will be embedded in struct > nubus_board. That will compound the terminlogy problem because drivers > will bind with boards, not with functional resources. Avoid this by > renaming struct nubus_dev as struct nubus_rsrc. "Functional resource" > is the vendor's terminology so this helps avoid confusion. > > Cc: Bartlomiej Zolnierkiewicz > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Acked-by: Bartlomiej Zolnierkiewicz for fbdev part > --- > drivers/net/ethernet/8390/mac8390.c | 26 ++++---- > drivers/net/ethernet/natsemi/macsonic.c | 22 +++---- > drivers/nubus/nubus.c | 105 ++++++++++++++++---------------- > drivers/nubus/proc.c | 15 ++--- > drivers/video/fbdev/macfb.c | 2 +- > include/linux/nubus.h | 30 +++++---- > 6 files changed, 98 insertions(+), 102 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics