From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_ Date: Thu, 18 Oct 2018 11:39:24 -0700 Message-ID: <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com> References: <1539875100-11121-1-git-send-email-clabbe@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Corentin Labbe , andrew@lunn.ch, davem@davemloft.net, fugang.duan@nxp.com Return-path: In-Reply-To: <1539875100-11121-1-git-send-email-clabbe@baylibre.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/18/2018 08:05 AM, Corentin Labbe wrote: > Since commit 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed"), the fec driver is unable to get any link. > This is due to missing SPEED_. But SPEED_1000 is defined in include/uapi/linux/ethtool.h as 1000, so surely this would amount to the same code paths being taken or am I missing something here? > > Fixes: 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed") > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index a17cc97..75fd7c9 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -1946,7 +1946,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) > > /* mask with MAC supported features */ > if (fep->quirks & FEC_QUIRK_HAS_GBIT) { > - phy_set_max_speed(phy_dev, 1000); > + phy_set_max_speed(phy_dev, SPEED_1000); > phy_remove_link_mode(phy_dev, > ETHTOOL_LINK_MODE_1000baseT_Half_BIT); > #if !defined(CONFIG_M5272) > @@ -1954,7 +1954,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) > #endif > } > else > - phy_set_max_speed(phy_dev, 100); > + phy_set_max_speed(phy_dev, SPEED_100); > > fep->link = 0; > fep->full_duplex = 0; > -- Florian