From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code from driver configs
Date: Thu, 8 Nov 2018 20:38:49 +0100 [thread overview]
Message-ID: <262b52e8-6823-ea9a-5730-2d018b953093@gmail.com> (raw)
In-Reply-To: <20181108183721.GE5259@lunn.ch>
On 08.11.2018 19:37, Andrew Lunn wrote:
>> {
>> .phy_id = 0x00008201,
>> .name = "RTL8201CP Ethernet",
>> - .phy_id_mask = 0x0000ffff,
>> .features = PHY_BASIC_FEATURES,
>> .flags = PHY_HAS_INTERRUPT,
>> }, {
>> .phy_id = 0x001cc816,
>> .name = "RTL8201F Fast Ethernet",
>> - .phy_id_mask = 0x001fffff,
>
> Hi Heiner
>
> "RTL8201CP Ethernet" has a mask of 0x0000ffff, where as all the others
> use 0x001fffff. Is this correct?
>
IMO none of the masks is correct. All of them should be 0xffffffff.
Nowadays the 32 bit PHYID is assembled from (MSB to LSB):
22 bits vendor OUI, 6 bit model number, 4 bit revision number
Just the old 8201 doesn't follow this scheme.
With the current masks, a PHYID 0x12348201 would be recognized as
Realtek 8201 too, what's obviously wrong.
> Andrew
>
next prev parent reply other threads:[~2018-11-09 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 20:52 [PATCH net-next 0/2] net: phy: use phy_id_mask value zero for exact match Heiner Kallweit
2018-11-07 20:53 ` [PATCH net-next 1/2] " Heiner Kallweit
2018-11-08 18:34 ` Andrew Lunn
2018-11-08 19:44 ` Florian Fainelli
2018-11-08 20:06 ` Heiner Kallweit
2018-11-08 20:53 ` Andrew Lunn
2018-11-08 23:06 ` Florian Fainelli
2018-11-07 20:54 ` [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code from driver configs Heiner Kallweit
2018-11-08 18:37 ` Andrew Lunn
2018-11-08 19:38 ` Heiner Kallweit [this message]
2018-11-08 23:05 ` [PATCH net-next 0/2] net: phy: use phy_id_mask value zero for exact match David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262b52e8-6823-ea9a-5730-2d018b953093@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).