From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net-next v4 00/11] Modify action API for implementing
 lockless actions
Date: Thu, 31 May 2018 06:01:32 -0400
Message-ID: <262fbd11-401e-90cf-4226-39b1604eb16d@mojatatu.com>
References: <1527753499-32124-1-git-send-email-vladbu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de,
        ast@kernel.org, daniel@iogearbox.net, edumazet@google.com,
        keescook@chromium.org, marcelo.leitner@gmail.com,
        kliteyn@mellanox.com
To: Vlad Buslov <vladbu@mellanox.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f182.google.com ([209.85.216.182]:44627 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754437AbeEaKBf (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 31 May 2018 06:01:35 -0400
Received: by mail-qt0-f182.google.com with SMTP id d3-v6so27114465qtp.11
        for <netdev@vger.kernel.org>; Thu, 31 May 2018 03:01:35 -0700 (PDT)
In-Reply-To: <1527753499-32124-1-git-send-email-vladbu@mellanox.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Vlad,

Can you try one simple test below with these patches?

#create an action
sudo $TC actions add action skbedit mark 1 pipe
#
sudo $TC qdisc del dev lo parent ffff:
sudo $TC qdisc add dev lo ingress
# bind action to filter....
sudo $TC filter add dev lo parent ffff: protocol ip prio 1 \
u32 match ip dst 127.0.0.1/32 flowid 1:1 action skbedit index 1

#now delete that action multiple times while it is still bound
sudo $TC actions del action skbedit index 1
sudo $TC actions del action skbedit index 1
sudo $TC actions del action skbedit index 1

#check the refcount and bindcount
sudo $TC -s actions ls action skbedit

#delete the filter (which should remove the bindcnt)

sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
u32 match ip dst 127.0.0.1/32 flowid 1:1

#check the refcount and bindcount
sudo $TC -s actions ls action skbedit

Current behavior: i believe the action is gone in this last step.
Your patches may change behavior so that the action action is still
around. I dont think this is a big deal, but just wanted to be sure
it is not something more unexpected.

cheers,
jamal