From: David Ahern <dsahern@gmail.com>
To: Leslie Monis <lesliemonis@gmail.com>,
Linux NetDev <netdev@vger.kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] tc: parse attributes with NLA_F_NESTED flag
Date: Sat, 18 Jan 2020 15:01:38 -0700 [thread overview]
Message-ID: <263a272f-770e-6757-916b-49f1036a8954@gmail.com> (raw)
In-Reply-To: <20200116155701.6636-1-lesliemonis@gmail.com>
On 1/16/20 8:57 AM, Leslie Monis wrote:
> diff --git a/tc/tc_class.c b/tc/tc_class.c
> index c7e3cfdf..39bea971 100644
> --- a/tc/tc_class.c
> +++ b/tc/tc_class.c
> @@ -246,8 +246,8 @@ static void graph_cls_show(FILE *fp, char *buf, struct hlist_head *root_list,
> "+---(%s)", cls_id_str);
> strcat(buf, str);
>
> - parse_rtattr(tb, TCA_MAX, (struct rtattr *)cls->data,
> - cls->data_len);
> + parse_rtattr_flags(tb, TCA_MAX, (struct rtattr *)cls->data,
> + cls->data_len, NLA_F_NESTED);
Petr recently sent a patch to update parse_rtattr_nested to add the
NESTED flag. Can you update this patch to use parse_rtattr_nested?
next prev parent reply other threads:[~2020-01-18 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 15:57 [PATCH] tc: parse attributes with NLA_F_NESTED flag Leslie Monis
2020-01-16 16:01 ` Leslie Monis
2020-01-18 22:01 ` David Ahern [this message]
2020-01-19 7:42 ` Leslie Monis
2020-01-19 19:16 ` Leslie Monis
2020-01-22 3:46 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263a272f-770e-6757-916b-49f1036a8954@gmail.com \
--to=dsahern@gmail.com \
--cc=lesliemonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).