From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEC5CCA479 for ; Mon, 4 Jul 2022 18:44:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiGDSoN (ORCPT ); Mon, 4 Jul 2022 14:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbiGDSoM (ORCPT ); Mon, 4 Jul 2022 14:44:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F1C6EAE56 for ; Mon, 4 Jul 2022 11:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656960251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XeGRpP6ZId+7T6ByVHweuCJUQTeXWvQUlmQR22hrw0=; b=OZ7QxvGlf04MKXihXxE4xpriIvjho6cvRkH1ubv2f1stqyWcnqqVJsTGUNG4n3Vj0CVQ9a Aa0kYwHFEcVd2Unoj+oUW2MqUFNbyqg4fhicmdTbKmKrF3/iCDYZ9U1OBsUqv0QuAIMmtO 3JxMrFN9XDQ/dSo43JtF+5iWAY1/1b8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-A8wgzCzNPlWqQ9s6EJyQvQ-1; Mon, 04 Jul 2022 14:44:09 -0400 X-MC-Unique: A8wgzCzNPlWqQ9s6EJyQvQ-1 Received: by mail-lf1-f69.google.com with SMTP id p2-20020a05651212c200b004814102d512so3285769lfg.1 for ; Mon, 04 Jul 2022 11:44:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version:user-agent:cc :subject:content-language:to:references:in-reply-to :content-transfer-encoding; bh=/XeGRpP6ZId+7T6ByVHweuCJUQTeXWvQUlmQR22hrw0=; b=FrjeL0IGvJ0r3kOClRha1KnQvjWRsKz64Q+UuYKn3s/tQ4DFuQM+WXBMjJ8yb+lyz6 XubYl1kdYMr4cZAsz+Of1LO8P4Hw8YARI/MmhyrbFz1gz7cU1DV8wRLOrxVvhINywdXJ UeBukC8h1Caux8magEEpOzX8Tw9MoheANKJ/+XbTPIj22yizIEouHHrtyc3z0xhjW2dL fjMqekrCoFxlbRgyOhIgvEk0DlCKTuryt+/AAJ5oY80tyWKBrRm2jPJf1Aqu4C/AxKgE 2229EITRlGvVMqciRCG2un4b/h6UJ3xyJQ3wFR94IDc2BfyDncf5IMk9jqVtl7W1S8MD NP0A== X-Gm-Message-State: AJIora9DiT2SQJyTI2NNzFhr8wSu3ggH/2Zjg12ne2MAORsGCONTcxib 96fxtPGVn3LOA2lSy2spBcjwCVLy9LTPRtbyOh3A+DWpuU7gOvdejtiAUn6giWwAACi47fL6ABf wEdN5NtkgIJKuIYpy X-Received: by 2002:a2e:a786:0:b0:25b:c51a:2c0b with SMTP id c6-20020a2ea786000000b0025bc51a2c0bmr17302937ljf.215.1656960248339; Mon, 04 Jul 2022 11:44:08 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sUjZDQTJKS/cC/EbwD6uXZ8y+pFvj472qgkIKZD5nHhQ69eebfOBxPU6CyfijqaCYd1r2I6g== X-Received: by 2002:a2e:a786:0:b0:25b:c51a:2c0b with SMTP id c6-20020a2ea786000000b0025bc51a2c0bmr17302926ljf.215.1656960248133; Mon, 04 Jul 2022 11:44:08 -0700 (PDT) Received: from [192.168.0.50] (87-59-106-155-cable.dk.customer.tdc.net. [87.59.106.155]) by smtp.gmail.com with ESMTPSA id c2-20020ac25f62000000b00478f3fe716asm5254746lfc.200.2022.07.04.11.44.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 11:44:07 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <263b8398-01fa-a8df-09d9-69bd8e49bc1e@redhat.com> Date: Mon, 4 Jul 2022 20:44:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Cc: brouer@redhat.com, "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexei Starovoitov , Daniel Borkmann , Network Development , "Fijalkowski, Maciej" , Jonathan Lemon , Andrii Nakryiko , Jesper Dangaard Brouer , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , bpf , Xdp Subject: Re: [PATCH bpf-next] selftests, bpf: remove AF_XDP samples Content-Language: en-US To: Magnus Karlsson , Jesper Dangaard Brouer References: <20220630093717.8664-1-magnus.karlsson@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 30/06/2022 16.20, Magnus Karlsson wrote: > On Thu, Jun 30, 2022 at 3:44 PM Jesper Dangaard Brouer > wrote: >> >> >> On 30/06/2022 11.37, Magnus Karlsson wrote: >>> From: Magnus Karlsson >>> >>> Remove the AF_XDP samples from samples/bpf as they are dependent on >>> the AF_XDP support in libbpf. This support has now been removed in the >>> 1.0 release, so these samples cannot be compiled anymore. Please start >>> to use libxdp instead. It is backwards compatible with the AF_XDP >>> support that was offered in libbpf. New samples can be found in the >>> various xdp-project repositories connected to libxdp and by googling. >>> >>> Signed-off-by: Magnus Karlsson >> >> Will you (or Maciej) be submitting these samples to XDP-tools[1] which >> is the current home for libxdp or maybe BPF-examples[2] ? >> >> [1] https://github.com/xdp-project/xdp-tools >> [2] https://github.com/xdp-project/bpf-examples >> >> I know Toke is ready to take over maintaining these, but we will >> appreciate someone to open a PR with this code... >> >>> --- >>> MAINTAINERS | 2 - >>> samples/bpf/Makefile | 9 - >>> samples/bpf/xdpsock.h | 19 - >>> samples/bpf/xdpsock_ctrl_proc.c | 190 --- >>> samples/bpf/xdpsock_kern.c | 24 - >>> samples/bpf/xdpsock_user.c | 2019 ------------------------------- >>> samples/bpf/xsk_fwd.c | 1085 ----------------- >> >> The code in samples/bpf/xsk_fwd.c is interesting, because it contains a >> buffer memory manager, something I've seen people struggle with getting >> right and performant (at the same time). > > I can push xsk_fwd to BPF-examples. Though I do think that xdpsock has > become way too big to serve as a sample. It slowly turned into a catch > all demonstrating every single feature of AF_XDP. We need a minimal > example and then likely other samples for other features that should > be demoed. So I suggest that xdpsock dies here and we start over with > something minimal and use xsk_fwd for the forwarding and mempool > example. I trust that we in bpf-examples[0] will see a PR with this from you/Intel, so: Acked-by: Jesper Dangaard Brouer > Toke, I think you told me at Recipes in Paris that someone from RedHat > was working on an example. Did I remember correctly? > >> You can get my ACK if someone commits to port this to [1] or [2], or a >> 3rd place that have someone what will maintain this in the future. >> [0] https://github.com/xdp-project/bpf-examples/