From: David Ahern <dsahern@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: replace sleeps in fcnal-test with waits
Date: Tue, 9 Sep 2025 16:59:28 -0600 [thread overview]
Message-ID: <263f7204-6f5b-4bbc-8c05-222cdb04fb15@kernel.org> (raw)
In-Reply-To: <20250909153346.4fa8c369@kernel.org>
On 9/9/25 4:33 PM, Jakub Kicinski wrote:
> On Mon, 8 Sep 2025 13:09:49 -0700 Jakub Kicinski wrote:
>> kill_procs()
>> {
>> killall nettest ping ping6 >/dev/null 2>&1
>> - sleep 1
>> + slowwait 2 sh -c 'test -z "$(pgrep '"'^(nettest|ping|ping6)$'"')"'
>> }
>
> This makes some ping tests fail.
>
> https://netdev-3.bots.linux.dev/vmksft-net/results/289602/129-fcnal-other-sh/stdout
> https://netdev-3.bots.linux.dev/vmksft-net/results/289602/128-fcnal-ipv6-sh/stdout
>
> I only tested with debug kernels, but the non-debug get upset.
> I'll resend just the wait_local_port_listen changes. If the change
> gets more complex it's probably good to separate them out in the first
> place.
That is surprising to me. I will take look tomorrow.
next prev parent reply other threads:[~2025-09-09 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 20:09 [PATCH net-next v2] selftests: net: replace sleeps in fcnal-test with waits Jakub Kicinski
2025-09-09 22:33 ` Jakub Kicinski
2025-09-09 22:59 ` David Ahern [this message]
2025-09-10 0:03 ` Jakub Kicinski
2025-09-10 2:17 ` David Ahern
2025-09-10 2:34 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263f7204-6f5b-4bbc-8c05-222cdb04fb15@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).