From: Florian Fainelli <f.fainelli@gmail.com>
To: Jose Abreu <jose.abreu@synopsys.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Joao Pinto <joao.pinto@synopsys.com>
Subject: Re: [PATCH net-next v2] net: phy: Also request modules for C45 IDs
Date: Sun, 02 Dec 2018 09:30:52 -0800 [thread overview]
Message-ID: <26495C42-021B-4C72-ABF2-9C7FC951807E@gmail.com> (raw)
In-Reply-To: <beb4b2e3946fc0d7252804a8458c7643f67c1dfc.1543764549.git.joabreu@synopsys.com>
On December 2, 2018 7:33:14 AM PST, Jose Abreu <jose.abreu@synopsys.com> wrote:
>Logic of phy_device_create() requests PHY modules according to PHY ID
>but for C45 PHYs we use different field for the IDs.
>
>Let's also request the modules for these IDs.
>
>Changes from v1:
>- Only request C22 modules if C45 are not present (Andrew)
Usually you can put the patch changelog under the '---' such that it gets stripped out when applying, not a big deal at all.
I don't have an easy way of testing this at the moment but this looks good:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
next prev parent reply other threads:[~2018-12-02 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 15:33 [PATCH net-next v2] net: phy: Also request modules for C45 IDs Jose Abreu
2018-12-02 16:09 ` Andrew Lunn
2018-12-02 17:30 ` Florian Fainelli [this message]
2018-12-04 0:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26495C42-021B-4C72-ABF2-9C7FC951807E@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).