From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets" Date: Tue, 12 Jun 2018 10:13:16 -0700 Message-ID: <264f1cab-1ff6-d4b5-c897-78e1944f45fa@gmail.com> References: <20180612170555.11733-1-bart.vanassche@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, =?UTF-8?Q?Maciej_=c5=bbenczykowski?= , Eric Dumazet To: Bart Van Assche , "David S . Miller" Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:44365 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933076AbeFLRNS (ORCPT ); Tue, 12 Jun 2018 13:13:18 -0400 Received: by mail-pl0-f67.google.com with SMTP id z9-v6so14727950plk.11 for ; Tue, 12 Jun 2018 10:13:18 -0700 (PDT) In-Reply-To: <20180612170555.11733-1-bart.vanassche@wdc.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/12/2018 10:05 AM, Bart Van Assche wrote: > Revert the patch mentioned in the subject because it breaks at least > the Avahi mDNS daemon. That patch namely causes the Ubuntu 18.04 Avahi > daemon to fail to start: > > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully called chroot(). > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Successfully dropped remaining capabilities. > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: No service file found in /etc/avahi/services. > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: SO_REUSEADDR failed: Structure needs cleaning > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: SO_REUSEADDR failed: Structure needs cleaning > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: Failed to create server: No suitable network protocol available > Jun 12 09:49:24 ubuntu-vm avahi-daemon[529]: avahi-daemon 0.7 exiting. > Jun 12 09:49:24 ubuntu-vm systemd[1]: avahi-daemon.service: Main process exited, code=exited, status=255/n/a > Jun 12 09:49:24 ubuntu-vm systemd[1]: avahi-daemon.service: Failed with result 'exit-code'. > Jun 12 09:49:24 ubuntu-vm systemd[1]: Failed to start Avahi mDNS/DNS-SD Stack. > > Fixes: f396922d862a ("net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets") > Cc: Maciej Żenczykowski > Cc: Eric Dumazet > Signed-off-by: Bart Van Assche > --- > net/core/sock.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) Yes, this change probably broke a lot of applications, unfortunately. Acked-by: Eric Dumazet