From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A61EC169C4 for ; Mon, 11 Feb 2019 18:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C053F21B18 for ; Mon, 11 Feb 2019 18:04:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAmDVKsY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731338AbfBKSEX (ORCPT ); Mon, 11 Feb 2019 13:04:23 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35902 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727896AbfBKSEX (ORCPT ); Mon, 11 Feb 2019 13:04:23 -0500 Received: by mail-pg1-f196.google.com with SMTP id r124so578668pgr.3 for ; Mon, 11 Feb 2019 10:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bgfrAVJoER1FmmU74cy7J2Rx7AxRAki4pGxjEJf1zYQ=; b=TAmDVKsYA+edtaXNnR3orT/sr+N4J6HJ9x0wABUruk+8TPuXIzzlt6wu0XMyy2/a9a sMnwX7lfb8V0e3gDCwir61jBDoRz6yxAdNUd8hDcRuC0JLqZQd9jSw67otVOH2n2EXYr n7LDgX4O82OxvkhGQIKo+znYSP9vwLfJnb4LZPoBhDhu13ntV6BW1I4Kkax2h5Usy6dd DCFqasfocYetyFA6++Fs/wK/ZerG/yrOCi+wfx9DsTO1MNhQaKwC0jt9NtBp7mLaneGN Nlr1hGywTK6BY1QJ1dUs9Ebz9P5tT9FjY2el7u2CHB6Sgg62JF4oEe16GSWgevynlPnT DYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bgfrAVJoER1FmmU74cy7J2Rx7AxRAki4pGxjEJf1zYQ=; b=at753Dom2cB3pECmNyttIRK5mDXXVelpMx+B3JXYhmPUtfEi0ogAclszbtMfmQP+JD 8eFVos2vQWjtplTnq+3bTUvoH9xw5652zvG/DiaNtQoVb+Q1Un2z8w+6klbydkeWlC94 MQjwEGuhuMPGt6I6PR0EhicwxOTfxVGbY0Eykk+85k7vl1cD9lApL7qLgAGECqBRmGmD oRPp5sJeoYZyoXgOgUr91oRgBTltJ0Be8snFvHJ+bRtw2RnzNQWbt9ssGFG5HhMf7xat XCInwCW7Inla/bI0uImJZSn12aHMcheme3wQltJUB25Xw/aWhYWLyW/MNu37fBr1EY9V A6zA== X-Gm-Message-State: AHQUAuaJYBGebCUK1uo/6Wpvgf+zHj5CPxb0VNQ6fDtT/8DToAhVK1c7 9nr/1Ut/WQRfifI69UT1fpwTS3kt X-Google-Smtp-Source: AHgI3IaBCOvxXAYq3OJSAkxCrYnujMiJVVQklFm/x8Rqce3ijjLxGeyVwy1qeBeNqRI6C4xSMhF/IQ== X-Received: by 2002:a62:7086:: with SMTP id l128mr37837060pfc.68.1549908261229; Mon, 11 Feb 2019 10:04:21 -0800 (PST) Received: from [10.67.49.102] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id a187sm9729423pfb.61.2019.02.11.10.04.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 10:04:20 -0800 (PST) Subject: Re: Possible bug into DSA2 code. To: Rodolfo Giometti , Andrew Lunn Cc: Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org References: <528f797d-445b-a314-d8ef-db15a3b6a8ce@enneenne.com> <20190209193409.GI30856@lunn.ch> <084b3973-88b9-8c71-50d5-9d773999ad04@enneenne.com> <49728829-49cc-6d6a-04b1-ccfc1e5266dd@enneenne.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <2651a882-c5ab-ba3b-ef4c-731dca90147d@gmail.com> Date: Mon, 11 Feb 2019 10:01:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <49728829-49cc-6d6a-04b1-ccfc1e5266dd@enneenne.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/11/19 9:51 AM, Rodolfo Giometti wrote: > On 11/02/2019 18:28, Florian Fainelli wrote: >> On 2/10/19 3:45 AM, Rodolfo Giometti wrote: >>> On 09/02/2019 20:34, Andrew Lunn wrote: >>>>> So we I see two possible solutions: >>>>> >>>>> 1) having both ds->slave_mii_bus and ds->ops->phy_read already >>>>> defined is an >>>>> error, then it must be signaled to the calling code, or >>>> >>>> I don't think we can do that. mv88e6xxx optionally instantiates the >>>> MDIO busses, depending on what is in device tree. If there is no mdio >>>> property, we need the DSA core to create an MDIO bus. >>> >>> OK, but using the following check to know if DSA did such allocation is >>> not correct because DSA drivers can allocate it by their own: >>> >>> static void dsa_switch_teardown(struct dsa_switch *ds) >>> { >>>          if (ds->slave_mii_bus && ds->ops->phy_read) >>>                  mdiobus_unregister(ds->slave_mii_bus); >>> >>> Maybe can we add a flag to register ds->slave_mii_bus allocation by DSA? >> >> If drivers allocate the slave_mii_bus, or use it as a pointer to their >> bus, then they should not be providing a ds->ops->phy_read() callback >> since we assume they would have mii_bus::read and mii_bus::write set to >> their driver internal version. > > I see, so having ds->slave_mii_bus and ds->ops->phy_read both not NULL > into dsa_switch_setup() is a potential bug, I suppose... If so why not > adding a BUG_ON() call to signal it instead of doing nothing? :-o If you have both non NULL, then your driver did allocate ds->slave_mii_bus on its own, and also assigned a valid ds->ops->phy_read() then things will work, except that ds->ops->phy_read() will not be used. And yes, that is going to be blowing away when the whole DSA tree gets teardowned. If you want to add a check for that condition, that would be a good thing, just not a BUG_ON(), propagate an error back to the caller and abort the tree/switch probing. -- Florian