From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6551F198A05 for ; Thu, 12 Sep 2024 22:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726179425; cv=none; b=WK5uqAAObfSFk87xdSRq9zHIT8GG9dNA0ixyR2ZHLZFhxsCCesknEas/DpcCzqb6Kd5kcCE6PtZu265uFoLXeuxBk8TjSoplHy9dkkoGzZTnxeo56tQEeYVg/HE8L6OSsMhTS1c3+A94cPgIcd48gfKKKuo4BJ/Q/LXurTybxrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726179425; c=relaxed/simple; bh=7jW1lpk3kIMO+KnNV43hPB0+le0/il1cP3oT2VYmTW0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G/65AZgJU0q6NZT0oO9B3TMbEFHOm+8mWv6JDtqzEOrbUgjMBhEk5nXgtwBGgbCRlx70XYd28Exb7cwM5gWNTYHDzai1SthlTPcx92GuJbVdgo5uN4wDX0AhB88WjURrzten7ok7uBkEjZKwrg5wnpY6iJEaevvouGoZj4IpU+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fM2zoiHp; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fM2zoiHp" Message-ID: <26a35c93-5a59-4ca1-ba62-01258767b214@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726179420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xcAaAUH/XpTJobVFOPAuYyrAxzloWB0KzX4fS/1XGOU=; b=fM2zoiHpGWPGwkitjqjDqi/lXNkI8cgS0A0+zleMwQ4XHjvrQ1V9av3KieNLHH/nu33yF8 XBw+yqqjvQW4ziMUXx2TarBUNGgQomrxHVfoLKp+/q4NY/8gAznD4pBOqAMCuFzJYnjQaa 02374pU5iBKNCnMM/j4EvusX1JkWDaQ= Date: Thu, 12 Sep 2024 23:16:55 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi_add To: Brett Creeley , alexanderduyck@fb.com, kuba@kernel.org, kernel-team@meta.com, davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jdamato@fastly.com, stable@vger.kernel.org References: <20240912174922.10550-1-brett.creeley@amd.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20240912174922.10550-1-brett.creeley@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 12/09/2024 18:49, Brett Creeley wrote: > The driver calls netif_napi_set_irq() and then calls netif_napi_add(), > which calls netif_napi_add_weight(). At the end of > netif_napi_add_weight() is a call to netif_napi_set_irq(napi, -1), which > clears the previously set napi->irq value. Fix this by calling > netif_napi_set_irq() after calling netif_napi_add(). > > This was found when reviewing another patch and I have no way to test > this, but the fix seemed relatively straight forward. > Cc: stable@vger.kernel.org > Fixes: bc6107771bb4 ("eth: fbnic: Allocate a netdevice and napi vectors with queues") > Signed-off-by: Brett Creeley I agree that irq vector is lost without this patch. Reviewed-by: Vadim Fedorenko