Re: [PATCH iwl-next 2/2] idpf: add direct method for disciplining Tx timestamping

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 02/09/2025 11:50, Anton Nadezhdin wrote:
> From: Milena Olech <milena.olech@intel.com>
> 
> Currently IDPF supports only mailbox access to PHC operations and
> Tx timestamping, however the driver shall also be able to handle direct
> access. The difference is that PHC/timestamps actions are performed
> directly, through BAR registers, instead of sending a virtchnl message to
> CP. Registers offsets are negotiated with the CP during the capabilities
> negotiation.
> 
> Signed-off-by: Milena Olech <milena.olech@intel.com>
> Co-developed-by: Anton Nadezhdin <anton.nadezhdin@intel.com>
> Signed-off-by: Anton Nadezhdin <anton.nadezhdin@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

[...]

> -static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb)
> +static void idpf_tx_read_tstamp(struct idpf_tx_queue *txq, struct sk_buff *skb,
> +				u32 buf_id)
>   {
>   	struct idpf_ptp_vport_tx_tstamp_caps *tx_tstamp_caps;
> -	struct idpf_ptp_tx_tstamp_status *tx_tstamp_status;
> +	struct idpf_ptp_tx_tstamp_status *tx_tstamp_status = NULL;

this breaks reverse x-mass tree aligment...

> +	enum idpf_ptp_access access;
> +	int err;