* [PATCH] net: wangxun: move PHYLINK dependency
@ 2025-12-16 21:35 Arnd Bergmann
2025-12-18 6:47 ` Vadim Fedorenko
2026-01-02 11:21 ` Russell King (Oracle)
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-12-16 21:35 UTC (permalink / raw)
To: Jiawen Wu, Mengyuan Lou, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Russell King
Cc: Arnd Bergmann, Vadim Fedorenko, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The LIBWX library code is what calls into phylink, so any user of
it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'
Add the 'select PHYLINK' line in the libwx option directly so this will
always be enabled for all current and future wangxun drivers, and remove
the now duplicate lines.
Fixes: a0008a3658a3 ("net: wangxun: add ngbevf build")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/wangxun/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
index d138dea7d208..ec278f99d295 100644
--- a/drivers/net/ethernet/wangxun/Kconfig
+++ b/drivers/net/ethernet/wangxun/Kconfig
@@ -21,6 +21,7 @@ config LIBWX
depends on PTP_1588_CLOCK_OPTIONAL
select PAGE_POOL
select DIMLIB
+ select PHYLINK
help
Common library for Wangxun(R) Ethernet drivers.
@@ -29,7 +30,6 @@ config NGBE
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
select LIBWX
- select PHYLINK
help
This driver supports Wangxun(R) GbE PCI Express family of
adapters.
@@ -48,7 +48,6 @@ config TXGBE
depends on PTP_1588_CLOCK_OPTIONAL
select MARVELL_10G_PHY
select REGMAP
- select PHYLINK
select HWMON if TXGBE=y
select SFP
select GPIOLIB
@@ -71,7 +70,6 @@ config TXGBEVF
depends on PCI_MSI
depends on PTP_1588_CLOCK_OPTIONAL
select LIBWX
- select PHYLINK
help
This driver supports virtual functions for SP1000A, WX1820AL,
WX5XXX, WX5XXXAL.
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: wangxun: move PHYLINK dependency
2025-12-16 21:35 [PATCH] net: wangxun: move PHYLINK dependency Arnd Bergmann
@ 2025-12-18 6:47 ` Vadim Fedorenko
2026-01-02 11:21 ` Russell King (Oracle)
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-12-18 6:47 UTC (permalink / raw)
To: Arnd Bergmann, Jiawen Wu, Mengyuan Lou, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Russell King
Cc: Arnd Bergmann, netdev, linux-kernel
On 16/12/2025 21:35, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The LIBWX library code is what calls into phylink, so any user of
> it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:
>
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
> wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
> wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
> wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
> wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
> wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'
>
> Add the 'select PHYLINK' line in the libwx option directly so this will
> always be enabled for all current and future wangxun drivers, and remove
> the now duplicate lines.
>
> Fixes: a0008a3658a3 ("net: wangxun: add ngbevf build")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/wangxun/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index d138dea7d208..ec278f99d295 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -21,6 +21,7 @@ config LIBWX
> depends on PTP_1588_CLOCK_OPTIONAL
> select PAGE_POOL
> select DIMLIB
> + select PHYLINK
> help
> Common library for Wangxun(R) Ethernet drivers.
>
> @@ -29,7 +30,6 @@ config NGBE
> depends on PCI
> depends on PTP_1588_CLOCK_OPTIONAL
> select LIBWX
> - select PHYLINK
> help
> This driver supports Wangxun(R) GbE PCI Express family of
> adapters.
> @@ -48,7 +48,6 @@ config TXGBE
> depends on PTP_1588_CLOCK_OPTIONAL
> select MARVELL_10G_PHY
> select REGMAP
> - select PHYLINK
> select HWMON if TXGBE=y
> select SFP
> select GPIOLIB
> @@ -71,7 +70,6 @@ config TXGBEVF
> depends on PCI_MSI
> depends on PTP_1588_CLOCK_OPTIONAL
> select LIBWX
> - select PHYLINK
> help
> This driver supports virtual functions for SP1000A, WX1820AL,
> WX5XXX, WX5XXXAL.
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: wangxun: move PHYLINK dependency
2025-12-16 21:35 [PATCH] net: wangxun: move PHYLINK dependency Arnd Bergmann
2025-12-18 6:47 ` Vadim Fedorenko
@ 2026-01-02 11:21 ` Russell King (Oracle)
1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2026-01-02 11:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jiawen Wu, Mengyuan Lou, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Arnd Bergmann,
Vadim Fedorenko, netdev, linux-kernel
On Tue, Dec 16, 2025 at 10:35:42PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The LIBWX library code is what calls into phylink, so any user of
> it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:
>
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
> wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
> wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
> wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
> wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
> x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
> wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'
>
> Add the 'select PHYLINK' line in the libwx option directly so this will
> always be enabled for all current and future wangxun drivers, and remove
> the now duplicate lines.
>
> Fixes: a0008a3658a3 ("net: wangxun: add ngbevf build")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-02 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-16 21:35 [PATCH] net: wangxun: move PHYLINK dependency Arnd Bergmann
2025-12-18 6:47 ` Vadim Fedorenko
2026-01-02 11:21 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).