From: David Ahern <dsahern@gmail.com>
To: Petr Machata <me@pmachata.org>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Po.Liu@nxp.com, toke@toke.dk,
dave.taht@gmail.com, edumazet@google.com, tahiliani@nitk.edu.in,
leon@kernel.org
Subject: Re: [PATCH iproute2-next 3/6] lib: Move sprint_size() from tc here, add print_size()
Date: Tue, 1 Dec 2020 21:07:12 -0700 [thread overview]
Message-ID: <26d00984-baf6-7d30-9edc-04dfd29193c6@gmail.com> (raw)
In-Reply-To: <87k0u1no8g.fsf@nvidia.com>
On 12/1/20 3:41 PM, Petr Machata wrote:
>
>> Also, instead of magic SPRINT_BSIZE, why not take a len param (and
>> name it snprint_size)?
>
> Because keeping the interface like this makes it possible to reuse the
> macroized bits in q_cake. I feel like the three current users are
> auditable enough that the implied length is not a big deal. And no new
> users should pop up, as the comment at the function makes clear.
>
seems reasonable and this reduces the number of users of sprint_size.
next prev parent reply other threads:[~2020-12-02 4:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 22:59 [PATCH iproute2-next 0/6] Move rate and size parsing and output to lib Petr Machata
2020-11-30 22:59 ` [PATCH iproute2-next 1/6] Move the use_iec declaration to the tools Petr Machata
2020-11-30 22:59 ` [PATCH iproute2-next 2/6] lib: Move print_rate() from tc here; modernize Petr Machata
2020-12-01 0:35 ` Stephen Hemminger
2020-12-01 22:56 ` Petr Machata
2020-11-30 22:59 ` [PATCH iproute2-next 3/6] lib: Move sprint_size() from tc here, add print_size() Petr Machata
2020-12-01 0:39 ` Stephen Hemminger
2020-12-01 22:41 ` Petr Machata
2020-12-02 4:07 ` David Ahern [this message]
2020-11-30 22:59 ` [PATCH iproute2-next 4/6] lib: Move get_rate(), get_rate64() from tc here Petr Machata
2020-11-30 22:59 ` [PATCH iproute2-next 5/6] lib: Move get_size() " Petr Machata
2020-11-30 22:59 ` [PATCH iproute2-next 6/6] lib: print_rate(): Fix formatting small rates in IEC mode Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d00984-baf6-7d30-9edc-04dfd29193c6@gmail.com \
--to=dsahern@gmail.com \
--cc=Po.Liu@nxp.com \
--cc=dave.taht@gmail.com \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=me@pmachata.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tahiliani@nitk.edu.in \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).