From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, luca.weiss@fairphone.com
Cc: krzk+dt@kernel.org, akoskovich@pm.me, konradybcio@kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, andersson@kernel.org,
netdev@vger.kernel.org, kuba@kernel.org,
linux-arm-msm@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, robh@kernel.org, edumazet@google.com,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, elder@kernel.org
Subject: Re: [5/6] arm64: dts: qcom: milos: Add IPA node
Date: Thu, 9 Apr 2026 10:00:16 +0200 [thread overview]
Message-ID: <26fa97ad-1e87-4b0b-9b31-c20f24a0a5ce@kernel.org> (raw)
In-Reply-To: <20260409075854.308955-1-pabeni@redhat.com>
On 09/04/2026 09:58, Paolo Abeni wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
>
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
...
>> +
>> + qcom,smem-states = <&smp2p_ipa_out 0>,
>> + <&smp2p_ipa_out 1>;
>> + qcom,smem-state-names = "ipa-clock-enabled-valid",
>> + "ipa-clock-enabled";
>> +
>> + sram = <&ipa_modem_tables>;
>> ^^^^^^^^^^^^^^^^^^
>
> Is the ipa_modem_tables label defined anywhere? The Device Tree Compiler
> will fail with "Reference to non-existent node or label
> 'ipa_modem_tables'" if this label doesn't exist.
Paul, please ignore all of such review from AI tools. It is completely
wrong and pointless.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-09 8:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 16:43 [PATCH 0/6] IPA v5.2 support for Milos and Fairphone (Gen. 6) Luca Weiss
2026-04-03 16:43 ` [PATCH 1/6] net: ipa: fix GENERIC_CMD register field masks for IPA v5.0+ Luca Weiss
2026-04-08 16:34 ` Simon Horman
2026-04-03 16:43 ` [PATCH 2/6] net: ipa: fix event ring index not programmed " Luca Weiss
2026-04-08 16:35 ` Simon Horman
2026-04-03 16:43 ` [PATCH 3/6] dt-bindings: net: qcom,ipa: add Milos compatible Luca Weiss
2026-04-05 8:03 ` Krzysztof Kozlowski
2026-04-03 16:43 ` [PATCH 4/6] net: ipa: add IPA v5.2 configuration data Luca Weiss
2026-04-08 16:36 ` Simon Horman
2026-04-03 16:43 ` [PATCH 5/6] arm64: dts: qcom: milos: Add IPA node Luca Weiss
2026-04-03 19:27 ` Dmitry Baryshkov
2026-04-07 10:30 ` Konrad Dybcio
2026-04-09 7:58 ` [5/6] " Paolo Abeni
2026-04-09 8:00 ` Krzysztof Kozlowski [this message]
2026-04-03 16:43 ` [PATCH 6/6] arm64: dts: qcom: milos-fairphone-fp6: Enable IPA Luca Weiss
2026-04-03 19:27 ` Dmitry Baryshkov
2026-04-09 8:26 ` Luca Weiss
2026-04-09 7:46 ` [PATCH 0/6] IPA v5.2 support for Milos and Fairphone (Gen. 6) Paolo Abeni
2026-04-09 8:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26fa97ad-1e87-4b0b-9b31-c20f24a0a5ce@kernel.org \
--to=krzk@kernel.org \
--cc=akoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox