From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v6 bpf-next 2/2] bpf: add tests for direct packet access from CGROUP_SKB Date: Fri, 19 Oct 2018 07:58:28 -0700 Message-ID: <27029e13-b317-4478-e3d7-8b49c3742c2b@gmail.com> References: <20181019055333.3829195-1-songliubraving@fb.com> <20181019055333.3829195-3-songliubraving@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, edumazet@google.com To: Song Liu , netdev@vger.kernel.org Return-path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:37929 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbeJSXFA (ORCPT ); Fri, 19 Oct 2018 19:05:00 -0400 Received: by mail-pf1-f194.google.com with SMTP id f29-v6so16605620pff.5 for ; Fri, 19 Oct 2018 07:58:31 -0700 (PDT) In-Reply-To: <20181019055333.3829195-3-songliubraving@fb.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/18/2018 10:53 PM, Song Liu wrote: > Tests are added to make sure CGROUP_SKB cannot access: > tc_classid, data_meta, flow_keys > > and can read and write: > mark, prority, and cb[0-4] > > and can read other fields. > > To make selftest with skb->sk work, a dummy sk is added in > bpf_prog_test_run_skb(). > > Signed-off-by: Song Liu > --- > net/bpf/test_run.c | 7 + > tools/testing/selftests/bpf/test_verifier.c | 171 ++++++++++++++++++++ > 2 files changed, 178 insertions(+) > > diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c > index 0c423b8cd75c..87ea279cb095 100644 > --- a/net/bpf/test_run.c > +++ b/net/bpf/test_run.c > @@ -10,6 +10,8 @@ > #include > #include > #include > +#include > +#include > > static __always_inline u32 bpf_test_run_one(struct bpf_prog *prog, void *ctx, > struct bpf_cgroup_storage *storage[MAX_BPF_CGROUP_STORAGE_TYPE]) > @@ -115,6 +117,7 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr, > u32 retval, duration; > int hh_len = ETH_HLEN; > struct sk_buff *skb; > + struct sock sk = {0}; > void *data; > int ret; > A dummy on stack, Nah forget it. Please compile your test kernels with common debugging features, I am sure some horrible thing will show up. (Like debug_object_is_on_stack())