Re: [PATCH net-next v2] xsk: add indirect call for xsk_destruct_skb

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Jason Xing <kerneljasonxing@gmail.com>
Date: Sun, 26 Oct 2025 22:58:24 +0800

> From: Jason Xing <kernelxing@tencent.com>
> 
> Since Eric proposed an idea about adding indirect call for UDP and
> managed to see a huge improvement[1], the same situation can also be
> applied in xsk scenario.
> 
> This patch adds an indirect call for xsk and helps current copy mode
> improve the performance by around 1% stably which was observed with
> IXGBE at 10Gb/sec loaded. If the throughput grows, the positive effect
> will be magnified. I applied this patch on top of batch xmit series[2],
> and was able to see <5% improvement from our internal application
> which is a little bit unstable though.
> 
> Use INDIRECT wrappers to keep xsk_destruct_skb static as it used to
> be when the mitigation config is off.
> 
> [1]: https://lore.kernel.org/netdev/20251006193103.2684156-2-edumazet@google.com/
> [2]: https://lore.kernel.org/all/20251021131209.41491-1-kerneljasonxing@gmail.com/
> 
> Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Signed-off-by: Jason Xing <kernelxing@tencent.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> v2
> Link: https://lore.kernel.org/all/20251023085843.25619-1-kerneljasonxing@gmail.com/
> 1. use INDIRECT helpers (Alexander)
> ---
>  include/net/xdp_sock.h | 7 +++++++
>  net/core/skbuff.c      | 8 +++++---
>  net/xdp/xsk.c          | 3 ++-
>  3 files changed, 14 insertions(+), 4 deletions(-)
Thanks,
Olek