From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA3150276 for ; Thu, 3 Sep 2026 08:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788425118; cv=none; b=tdkw+YhXmHz/5jv48EohvtwEIPFQBcqMn5YFiHHZOtlD3gvTJzW11Umr2QF6b4/rThFwHlle9HaRusfQlbLkUBsapl/LN7T0Md52+DsTHTAiVoWW0sDykY8BA3qbit8cObBNyRD0DGR4kA6uHPENZtMODCCT6LzfCaO3tmgcvr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788425118; c=relaxed/simple; bh=3CkF/JSHjoWe06mwIEXtiMCqRfi8kLlB7paGwD8F9NM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CexhmIltGH8jsQmdKsV5z7/UIU4AGNKwvZSyZag1tGqOqYFqfbMz7oIUxcz/2sHUWKf1O67PlDvbbLc78IBeJfxjciPYaH+1Qgp+JE5TN/9kxnS70vGhze9If4cYW31rUm43x/GIf3gZunn8zeWRRnsd9Ja9hC88Hsk2BdcipjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=AmBlqR4y; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="AmBlqR4y" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 12A1D4E414E3; Thu, 3 Sep 2026 08:45:09 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D597F602B8; Thu, 3 Sep 2026 08:45:08 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C649D11C791C9; Thu, 3 Sep 2026 10:44:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788425103; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=I3POSKf1l//awqxiJqBaWGp6u9Aetu6Ug9QJG/mcoxA=; b=AmBlqR4yi+H5GQeKIjxkNzi6kZX3aEWZ8QCr/EcPduO6XYg/IwNnZ9vkAQYzDyyCDXAs47 JazVtt8sceaDeIRUwWVCPt9E528QZaJe3GlSuqVINZM7WrVNuyeyeERvZS2/YGk3gfc6Yx Fm9rOEZpk7lg11HFl/1AY6veXzz7lycr9VBy1ymsWzEyl5SoiUtTRnZHFU88cIwelGlMJe YLXI2aost0tfd5vmQdRuJeJtSbVke7QmyfJadI3wDFUkIEAHsMCAOCx6Yjn6jGSmWC1t4Z 6zokH2E1Xc+OQgDcM1pOHBxVZ0S0jMzeMdCetjn3vRV8Gns4xE/jPDQtQENm9Q== Message-ID: <2711c2ec-3e3c-4cfd-bda6-cfc832a873c2@bootlin.com> Date: Thu, 3 Sep 2026 10:44:53 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 08/10] net: stmmac: dwmac-rk: add SGMII support for RK3568 To: Coia Prant Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Vinod Koul , Maxime Coquelin , Alexandre Torgue , Lad Prabhakar , Romain Gantois , Heiner Kallweit , Neil Armstrong , Russell King , Shawn Lin , David Heidelberg , netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org References: <20260901150111.141037-1-coiaprant@gmail.com> <20260901150111.141037-9-coiaprant@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, >>> gmac_clk_enable() is now called before any register access, including >>> the SGMII mode setup path. Previously SGMII mode would bypass the >>> clock enable via a goto, which could cause synchronous external abort >>> when accessing MAC registers with the clock domain disabled. >>> >>> Also clean up the error handling in rk_gmac_powerup() by using a >>> unified clk_disable label, and add error handling for the default >>> (unhandled interface) case. >>> >>> SGMII In-band vs Out-of-band >>> ============================ >>> On RK3568, the MAC clock is fixed at 125 MHz and cannot be dynamically >>> changed by the stmmac core's set_clk_tx_rate callback. In-band mode >>> works because the PCS handles rate adaptation internally. Out-of-band >>> mode does not work because the MAC would need to change the clock rate >>> to 125/12.5/1.25 MHz for 1000/100/10 Mbps respectively, and the clock >>> is fixed. >>> >>> Enable default_an_inband for SGMII and disable the generic stmmac >>> set_clk_tx_rate callback. This forces phylink to use in-band mode, >>> where the PCS is responsible for speed/duplex negotiation. Without >>> this, the stmmac core would attempt to change the clock rate on speed >>> changes, causing TX to work but RX to fail. >>> >>> Link: https://dl.radxa.com/rock3/docs/hw/datasheet/Rockchip%20RK3568%20TRM%20Part1%20V1.1-20210301.pdf (Page 386) >>> Signed-off-by: Coia Prant >> >> [...] >> >>> +static int rk_pcs_init(struct stmmac_priv *priv) >>> +{ >>> + struct device_node *np = priv->device->of_node; >>> + struct device_node *pcs_node; >>> + struct dw_xpcs *xpcs; >>> + >>> + pcs_node = of_parse_phandle(np, "pcs-handle", 0); >>> + if (!pcs_node) >>> + return -ENODEV; >> >> Here aswell you make it mandatory to have a PCS, as the generic pcs logic >> introduced in patch 1 doesn't handle -ENODEV, it treats it as any other >> error. >> >> So, either you return 0 when there's no PCS (so that we don't break platforms >> that don't have one), or you handle -ENODEV gracefully in patch 1. >> >> Maxime >> > > Hi, > > Currently, `rk_pcs_init` is called only for SGMII, which requires a PCS. > > As it stands, only the RK3568 supports SGMII, so we won't break anything here. Ah yes, it's protected by if (plat_dat->phy_interface == PHY_INTERFACE_MODE_SGMII) { ... } My bad, this is fine then :) the intel thing from patch 1 is still standing though from what I can see ? or have I made the same error there ? Maxime