From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79D3063B3 for ; Fri, 11 Aug 2023 13:23:19 +0000 (UTC) Received: from out-114.mta1.migadu.com (out-114.mta1.migadu.com [IPv6:2001:41d0:203:375::72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEB44125 for ; Fri, 11 Aug 2023 06:23:17 -0700 (PDT) Message-ID: <271b76c6-a52a-0c8b-5560-8a72c4340faf@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691760195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SkZWE4XFj7n8PtSuWO95wRoJ9c9BRctbYRXHgzE+874=; b=q9k1tHJR1cMhrkd4lyzS4+BSxbHSM490dxoSUrrR8QHrxenoc5OqPCuV0LHLB4XLaiM0Dw N8ObBd2AOuHAaL+3bIkd10FDI6YsmHru3PRZOeZh6EbkHFkL+Pd8RPXucsT1d+yT5pTWU/ n+upeYSRMSeTp3dB4DCewzo6X1LIJiE= Date: Fri, 11 Aug 2023 14:23:08 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v3 6/9] ice: add admin commands to access cgu configuration Content-Language: en-US To: "Kubalewski, Arkadiusz" , Jakub Kicinski Cc: Jiri Pirko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Bart Van Assche , "intel-wired-lan@lists.osuosl.org" References: <20230809214027.556192-1-vadim.fedorenko@linux.dev> <20230809214027.556192-7-vadim.fedorenko@linux.dev> <20230810192102.2932d58f@kernel.org> <8d52ab61-e532-0ef8-4227-ea1ab469f4cb@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 11/08/2023 13:16, Kubalewski, Arkadiusz wrote: >> From: Vadim Fedorenko >> Sent: Friday, August 11, 2023 11:31 AM >> >> On 11/08/2023 03:21, Jakub Kicinski wrote: >>> On Wed, 9 Aug 2023 22:40:24 +0100 Vadim Fedorenko wrote: >>>> From: Arkadiusz Kubalewski >>>> >>>> Add firmware admin command to access clock generation unit >>>> configuration, it is required to enable Extended PTP and SyncE features >>>> in the driver. >>>> Add definitions of possible hardware variations of input and output pins >>>> related to clock generation unit and functions to access the data. >>> >>> Doesn't build, but hold off a little with reposting, please hopefully >>> I'll have more time tomorrow to review. >> >> Yeah, we've found the issue already and Arkadiusz has prepared a patch >> to fix it. I can do the repost once you are ok to review. > > Thanks Vadim, > > Just realized you have already replied on this.. > Ok, so I guess v4 after all. > > Thank you! > Arkadiusz Yeah, it will be v4 anyway