From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com, Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core
Date: Fri, 8 Mar 2024 09:01:01 +0100 [thread overview]
Message-ID: <272fcc64-a22c-4f19-8172-d1959276547e@linaro.org> (raw)
In-Reply-To: <20240307-net-v9-6-6e0cf3e6584d@outlook.com>
On 07/03/2024 12:34, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
>
> HiSilicon FEMAC core is also found on Hi3798MV200 SoC. Document it in
> binding.
>
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>
> # Conflicts:
> # Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
Drop
> ---
> Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> index 5cd2331668bc..4f8a07864eb4 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> @@ -16,6 +16,7 @@ properties:
> compatible:
> enum:
> - hisilicon,hi3516cv300-femac
> + - hisilicon,hi3798mv200-femac
As I asked two or three or four times: please express compatibility
(oneOf, items). Your driver suggests that they are compatible. If they
are not compatible, mention it in commit msg, but so far it suggests
they are compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-08 8:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:34 [PATCH net-next v9 0/9] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 1/9] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 2/9] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 3/9] net: mdio: hisi-femac: remove clock Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 4/9] dt-bindings: net: convert hisi-femac.txt to YAML Yang Xiwen via B4 Relay
2024-03-08 7:59 ` Krzysztof Kozlowski
2024-03-07 11:34 ` [PATCH net-next v9 5/9] dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core Yang Xiwen via B4 Relay
2024-03-07 22:11 ` Rob Herring
2024-03-08 8:01 ` Krzysztof Kozlowski [this message]
2024-03-08 8:02 ` Yang Xiwen
2024-03-08 8:40 ` Krzysztof Kozlowski
2024-03-07 11:34 ` [PATCH net-next v9 7/9] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 8/9] net: hisi_femac: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-03-08 8:02 ` Krzysztof Kozlowski
2024-03-08 8:07 ` Yang Xiwen
2024-03-08 8:09 ` Krzysztof Kozlowski
2024-03-08 8:18 ` Yang Xiwen
2024-03-08 8:22 ` Krzysztof Kozlowski
2024-03-07 11:34 ` [PATCH net-next v9 9/9] net: hisi_femac: remove unneeded MODULE_ALIAS() Yang Xiwen via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272fcc64-a22c-4f19-8172-d1959276547e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).