From: Arnd Bergmann <arnd@arndb.de>
To: Petko Manolov <petkan@mip-labs.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"xypron.glpk@gmx.de" <xypron.glpk@gmx.de>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, oneukum@suse.com,
linux@roeck-us.net
Subject: Re: [PATCH] net: pegasus: remove unused variables and labels
Date: Fri, 20 May 2016 11:58:47 +0200 [thread overview]
Message-ID: <2736625.RvDzKBHoOP@wuerfel> (raw)
In-Reply-To: <20160520093223.GJ21813@p310>
On Friday 20 May 2016 12:32:23 Petko Manolov wrote:
> Guys, come on. This code is not dead. This code is executed every time an
> ethernet packet is received. It takes care of various error statistics. More
> importantly, it sends the actual (reported by the adapter) packet length to the
> network layer along with the packet.
>
> This patch removes skb_put() and netif_rx() calls and effectively kills the RX
> path. Not to mention that the driver was not even compiled before sending the
> patch upstream.
>
> The only sensible, although cosmetic, change would be to replace:
>
> if (!count || count < 4)
>
> with
>
> if (count < 4)
>
> even though GCC takes care and it optimizes away "!count" condition.
>
> Please revert this patch before Linus pulls from the network tree.
>
Agreed. I failed to check the commit that introduced the warning for
the more serious problem.
Please revert e00be9e4d0ff, it just makes no sense.
Arnd
next prev parent reply other threads:[~2016-05-20 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:22 [PATCH] net: pegasus: remove unused variables and labels Arnd Bergmann
2016-05-20 9:32 ` Petko Manolov
2016-05-20 9:58 ` Arnd Bergmann [this message]
2016-05-20 16:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2736625.RvDzKBHoOP@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=petkan@mip-labs.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).