From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Date: Wed, 30 May 2018 20:03:11 -0700 Message-ID: <274f0b84-07f1-5cd5-e256-ce4b71358c14@intel.com> References: <1527180917-39737-1-git-send-email-sridhar.samudrala@intel.com> <1527180917-39737-3-git-send-email-sridhar.samudrala@intel.com> <20180530220635.206ee6d7@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: alexander.h.duyck@intel.com, virtio-dev@lists.oasis-open.org, jiri@resnulli.us, mst@redhat.com, kubakici@wp.pl, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, loseweigh@gmail.com, anjali.singhai@intel.com, aaron.f.brown@intel.com, davem@davemloft.net To: Stephen Hemminger Return-path: In-Reply-To: <20180530220635.206ee6d7@shemminger-XPS-13-9360> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 5/30/2018 7:06 PM, Stephen Hemminger wrote: > On Thu, 24 May 2018 09:55:14 -0700 > Sridhar Samudrala wrote: > >> Use the registration/notification framework supported by the generic >> failover infrastructure. >> >> Signed-off-by: Sridhar Samudrala > Why was this merged? It was never signed off by any of the netvsc maintainers, > and there were still issues unresolved. > > There are also namespaces issues I am fixing and this breaks them. > Will start my patch set with a revert for this. Sorry I would appreciate if you can make the fixes on top of this patch series. I tried hard to make sure that netvsc functionality and behavior doesn't change. It is possible that there could be some bugs introduced, but they can be fixed. Looks like Wei already found a bug and submitted a fix for that.